Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(insights): improve ZoneInsight subscription management #8153

Merged
merged 12 commits into from
Nov 1, 2023
Merged

fix(insights): improve ZoneInsight subscription management #8153

merged 12 commits into from
Nov 1, 2023

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Oct 26, 2023 •
edited
Loading

See #7535

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@michaelbeaumont michaelbeaumont mentioned this pull request Oct 26, 2023
Closed
5 tasks
lahabana
lahabana reviewed Oct 26, 2023
View reviewed changes
api/generic/insights.go Outdated Show resolved Hide resolved
@michaelbeaumont michaelbeaumont marked this pull request as ready for review October 26, 2023 14:26
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner October 26, 2023 14:26
@michaelbeaumont michaelbeaumont requested review from lobkovilya and lukidzi and removed request for a team October 26, 2023 14:26
@michaelbeaumont
refactor: reduce duplication
cf9173c 
Signed-off-by: Mike Beaumont <[email protected]>
jakubdyszkiewicz
jakubdyszkiewicz approved these changes Oct 30, 2023
View reviewed changes
pkg/gc/finalizer.go Outdated Show resolved Hide resolved
lobkovilya
lobkovilya approved these changes Oct 30, 2023
View reviewed changes
api/mesh/v1alpha1/dataplane_insight_helpers.go Outdated Show resolved Hide resolved
pkg/gc/finalizer.go Outdated Show resolved Hide resolved
pkg/gc/finalizer.go Outdated Show resolved Hide resolved
@lahabana lahabana mentioned this pull request Oct 31, 2023
Open
@michaelbeaumont michaelbeaumont merged commit d256a5e into kumahq:master Nov 1, 2023
@michaelbeaumont michaelbeaumont deleted the fix/finalizer-subs branch November 1, 2023 13:23
@lahabana lahabana changed the title fix(kuma-cp): improve ZoneInsight subscription management fix(insights): improve ZoneInsight subscription management Nov 3, 2023
@BrewTestBot BrewTestBot mentioned this pull request Nov 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahabana lahabana lahabana left review comments

@lukidzi lukidzi Awaiting requested review from lukidzi lukidzi is a code owner automatically assigned from kumahq/kuma-maintainers

@lobkovilya lobkovilya Awaiting requested review from lobkovilya

@jakubdyszkiewicz jakubdyszkiewicz Awaiting requested review from jakubdyszkiewicz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michaelbeaumont @lahabana @jakubdyszkiewicz @lobkovilya