fix: don't mark all previou zoneinsight subs disconnected

Signed-off-by: Mike Beaumont <[email protected]>

api/system/v1alpha1/zone_insight_helpers.go

@@ -7,7 +7,6 @@ import (
 	timestamppb "google.golang.org/protobuf/types/known/timestamppb"
 
 	"github.com/kumahq/kuma/api/generic"
-	util_proto "github.com/kumahq/kuma/pkg/util/proto"
 )
 
 var _ generic.Insight = &ZoneInsight{}
@@ -78,7 +77,6 @@ func (x *ZoneInsight) UpdateSubscription(s generic.Subscription) error {
 			return nil
 		}
 	}
-	x.finalizeSubscriptions()
 	x.Subscriptions = append(x.Subscriptions, kdsSubscription)
 	return nil
 }
@@ -94,18 +92,6 @@ func (x *ZoneInsight) CompactFinished() {
 	}
 }
 
-// If Global CP was killed ungracefully then we can get a subscription without a DisconnectTime.
-// Because of the way we process subscriptions the lack of DisconnectTime on old subscription
-// will cause wrong status.
-func (x *ZoneInsight) finalizeSubscriptions() {
-	now := util_proto.Now()
-	for _, subscription := range x.GetSubscriptions() {
-		if subscription.DisconnectTime == nil {
-			subscription.DisconnectTime = now
-		}
-	}
-}
-
 func NewVersion() *Version {
 	return &Version{
 		KumaCp: &KumaCpVersion{