Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rework AddFieldsFromCtx to be less combersome #8216

Open
lahabana opened this issue Oct 31, 2023 · 5 comments
Open

rework AddFieldsFromCtx to be less combersome #8216

lahabana opened this issue Oct 31, 2023 · 5 comments
Labels
kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@lahabana
Copy link
Contributor

What happened?

#8153 (comment)

The api is not great. logr now supports slog and slog can take InfoWithContext maybe that'd be a better way to add these: https://github.com/go-logr/logr#using-a-sloghandler-as-backend-for-logr
@lahabana lahabana added triage/pending This issue will be looked at on the next triage meeting kind/bug A bug labels Oct 31, 2023
@lahabana lahabana mentioned this issue Oct 31, 2023
Merged
5 tasks
@lahabana lahabana added triage/accepted The issue was reviewed and is complete enough to start working on it kind/improvement Improvement on an existing feature and removed triage/pending This issue will be looked at on the next triage meeting kind/bug A bug labels Nov 6, 2023
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Feb 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2024

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label Feb 5, 2024
@slonka slonka mentioned this issue Apr 26, 2024
Closed
5 tasks
@bartsmykla bartsmykla mentioned this issue Apr 27, 2024
Merged
5 tasks
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label May 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2024

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@slonka slonka removed the triage/stale Inactive for some time. It will be triaged again label May 6, 2024
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Aug 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 5, 2024

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lobkovilya lobkovilya removed the triage/stale Inactive for some time. It will be triaged again label Aug 5, 2024
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Nov 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lukidzi lukidzi removed the triage/stale Inactive for some time. It will be triaged again label Nov 12, 2024
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Feb 13, 2025
@github-actions GitHub Actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lukidzi lukidzi removed the triage/stale Inactive for some time. It will be triaged again label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lahabana @slonka @lobkovilya @lukidzi