chore(api-server): pass extensions context to rest endpoints #10094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `AddFieldFromCtx` in `HandleError` function we were passing fresh, empty context. Because of that whenever logger had custom `FromSpanLogValuesProcessorContext` passed, it was ignored. Now we are passing runtime extension context to all endpoint handlers which then are using `HandleFunction`, which allows us to provide in example mapper of OTEL trace ids to Datadog. Signed-off-by: Bart Smykla <[email protected]>
bartsmykla
requested review from
jakubdyszkiewicz and
lobkovilya
and removed request for
a team
Signed-off-by: Bart Smykla <[email protected]>
bartsmykla
force-pushed
the
chore/pass-extensions-context-to-rest-endpoints
branch
from
41f817d to
328cf04
Compare
slonka
reviewed
Apr 26, 2024
| @@ -40,6 +40,7 @@ var _ = Describe("Tokens Client", func() { | |||
| &zoneStaticTokenIssuer{}, | |||
| access.NoopDpTokenAccess{}, | |||
| zone_access.NoopZoneTokenAccess{}, | |||
| context.Background(), | |||
There was a problem hiding this comment.
isn't context the first parameter by design in go?
| } | ||
| if host == "127.0.0.1" || host == "::1" { | ||
| log.V(1).Info("authenticated as admin because requests originates from the same machine") | ||
| request.Request = request.Request.WithContext(user.Ctx(request.Request.Context(), user.Admin.Authenticated())) //nolint:contextcheck |
There was a problem hiding this comment.
why does this suddenly need a nolint?
|
Yeah, I also don't like it. Let me see if I could do something with #8216 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
AddFieldFromCtxinHandleErrorfunction we were passing fresh, empty context. Because of that whenever logger had customFromSpanLogValuesProcessorContextpassed, it was ignored. Now we are passing runtime extension context to all endpoint handlers which then are usingHandleError, which allows us to provide in example mapper of OTEL trace ids to Datadog.Checklist prior to review
syscall.Mkfifohave equivalent implementation on the other OSci/labels to run additional/fewer testsUPGRADE.md?