Cherry pick #2385 #2401 #2428 to 1.14 #2442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LaunchTemplateSpecification.Version is a pointer to string. When the pointer is nil, EC2 AutoScaling API considers the value to be "$Default", however aws.StringValue(ltSpec.Version) will return an empty string (which is not considered the same as "$Default" or a nil string pointer. So, in order to not pass an empty string as the version for the launch template when we communicate with the EC2 AutoScaling API using the information in the launchTemplate, we store the string "$Default" when the ltSpec.Version is a nil pointer. Issue kubernetes#1728
`session.New` is deprecated and requires the `AWS_SDK_LOAD_CONFIG` environment variable to be set in order to automatically call `AssumeRoleWithWebIdentity` when `AWS_WEB_IDENTITY_TOKEN_FILE` is set (which is not documented and most likely unintended).
k8s-ci-robot
added
cncf-cla: yes
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: losipiuk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@Jeffwan Shouldnt those be cherry-picked to 1.13 too. We updated SDK there and IIUC the |
|
@losipiuk I will file a PR for session one. Thanks I missed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2385 Ensure valid AWS LaunchTemplate version
#2401 Add g4dn instance type for AWS
#2428 AWS – use session.NewSession instead of session.New to