Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add g4dn instance type for AWS #2401

Merged
merged 2 commits into from
Oct 2, 2019
Merged

Conversation

Luke035
Copy link
Contributor

@Luke035 Luke035 commented Sep 30, 2019

Just added newly created AWS g4dn EC2 instances type on EC2 catalog

@k8s-ci-robot
Copy link
Contributor

Welcome @Luke035!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 30, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 30, 2019
@seh
Copy link

seh commented Oct 1, 2019

Is this a full regeneration, per the suggestion in #2376?

@Jeffwan
Copy link
Contributor

Jeffwan commented Oct 2, 2019

Even #2249 is done, we need a static list. Thanks. I will merge this one.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 2, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2019
@k8s-ci-robot k8s-ci-robot merged commit 9393cea into kubernetes:master Oct 2, 2019
@seh
Copy link

seh commented Oct 2, 2019

It's strange, though, that now we have the "g4dn" part of the family, but none of the rest of the "g4" family.

@Jeffwan
Copy link
Contributor

Jeffwan commented Oct 2, 2019

@seh yeah. At the beginning, aws give name g4 but eventually change to g4dn.

@Luke035
Copy link
Contributor Author

Luke035 commented Oct 2, 2019

I just want to add that, for the moment, g4dn are not supported in EKS (https://aws.amazon.com/it/blogs/aws/now-available-ec2-instances-g4-with-nvidia-t4-tensor-core-gpus/). Autoscaler works fine but the related EKS AMI still don't support NVIDIA T4. @Jeffwan do you know if there's any plan to support them soon?

@Luke035
Copy link
Contributor Author

Luke035 commented Oct 2, 2019

I just want to add that, for the moment, g4dn are not supported in EKS (https://aws.amazon.com/it/blogs/aws/now-available-ec2-instances-g4-with-nvidia-t4-tensor-core-gpus/). Autoscaler works fine but the related EKS AMI still don't support NVIDIA T4. @Jeffwan do you know if there's any plan to support them soon?

Ok, never mind https://aws.amazon.com/it/about-aws/whats-new/2019/09/amazon-eks-adds-support-for-g4-instance/

@seh
Copy link

seh commented Oct 2, 2019

At the beginning, aws give name g4 but eventually change to g4dn.

Oh, I hadn't noticed that, but I see it reflected in the page on the G4 family now. Thank you for pointing that out.

This isn't the first instance type family to include "dn" in a few of the names. Do you happen to know what "dn" stands for?

@Luke035
Copy link
Contributor Author

Luke035 commented Oct 2, 2019

At the beginning, aws give name g4 but eventually change to g4dn.

Oh, I hadn't noticed that, but I see it reflected in the page on the G4 family now. Thank you for pointing that out.

This isn't the first instance type family to include "dn" in a few of the names. Do you happen to know what "dn" stands for?

I think that d stands for disk attached (in fact if you manually launch the instance, you'll notice an additional disk attached) and n for network optimized. But it's just an hypothesis

@Jeffwan
Copy link
Contributor

Jeffwan commented Oct 3, 2019

Yeah. We just release support for G4 family on EKS this Monday. p3dn is the first one with dn in the name. I don't even know EC2 have the dn in the name. looks like @Luke035 hypothsis is correct. All dn instances have local SSD or NVMe and better network (25 Gigbit or more).

k8s-ci-robot added a commit that referenced this pull request Oct 11, 2019
k8s-ci-robot added a commit that referenced this pull request Oct 11, 2019
k8s-ci-robot added a commit that referenced this pull request Oct 11, 2019
k8s-ci-robot added a commit that referenced this pull request Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants