ensure valid AWS LaunchTemplate version #2385
Conversation
|
Welcome @jaypipes! |
k8s-ci-robot
added
do-not-merge/invalid-commit-message
The LaunchTemplateSpecification.Version is a pointer to string. When the pointer is nil, EC2 AutoScaling API considers the value to be "$Default", however aws.StringValue(ltSpec.Version) will return an empty string (which is not considered the same as "$Default" or a nil string pointer. So, in order to not pass an empty string as the version for the launch template when we communicate with the EC2 AutoScaling API using the information in the launchTemplate, we store the string "$Default" when the ltSpec.Version is a nil pointer. Issue kubernetes#1728
jaypipes
force-pushed
the
launch-template-default-version
branch
from
f8f8ab9 to
54f3076
Compare
k8s-ci-robot
removed
the
do-not-merge/invalid-commit-message
|
Great! Thanks for fixing this case. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jeffwan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
This should be a candidate to cherry-pick to >= 1.14 versions. We can do it later before CA release next version |
The LaunchTemplateSpecification.Version is a pointer to
string. When the pointer is nil, EC2 AutoScaling API considers the value
to be "$Default", however aws.StringValue(ltSpec.Version) will return an
empty string (which is not considered the same as "$Default" or a nil
string pointer. So, in order to not pass an empty string as the version
for the launch template when we communicate with the EC2 AutoScaling API
using the information in the launchTemplate, we store the string
"$Default" when the ltSpec.Version is a nil pointer.
Fixes #1728