Use spot instances for E2E on AWS #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubermatic-bot
added
the
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kron4eg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
approved
|
/hold I'd like to merge #1241 before this |
kubermatic-bot
added
do-not-merge/hold
xmudrii
reviewed
Apr 8, 2021
examples/terraform/aws/variables.tf
Outdated
| @@ -166,3 +166,8 @@ variable "static_workers_count" { | |||
| description = "number of static workers" | |||
| default = 0 | |||
| } | |||
|
|
|||
| variable "initial_machinedeployment_spotinstances" { | |||
| description = "use spot instances for initil machine-deployment" | |||
There was a problem hiding this comment.
Suggested change
| description = "use spot instances for initil machine-deployment" | |
| description = "use spot instances for initial machine-deployment" |
examples/terraform/aws/variables.tf
Outdated
|
|
||
| variable "initial_machinedeployment_spotinstances" { | ||
| description = "use spot instances for initil machine-deployment" | ||
| default = true |
There was a problem hiding this comment.
I think that we should set the default value to false and then override the value in E2E tests.
Suggested change
| default = true | |
| default = false |
|
/retest |
kron4eg
changed the title
|
/retest |
xmudrii
reviewed
Apr 8, 2021
Signed-off-by: Artiom Diomin <[email protected]>
Signed-off-by: Artiom Diomin <[email protected]>
Signed-off-by: Artiom Diomin <[email protected]>
Signed-off-by: Artiom Diomin <[email protected]>
Signed-off-by: Artiom Diomin <[email protected]>
Signed-off-by: Artiom Diomin <[email protected]>
Signed-off-by: Artiom Diomin <[email protected]>
This reverts commit e45c9b9.
|
/retest |
|
/unhold |
kubermatic-bot
removed
the
do-not-merge/hold
|
LGTM label has been added. Git tree hash: 582a5277a4205d1646eb39393fab52875f1e1c5c
|
hwuethrich
added a commit
to hwuethrich/kubeone
that referenced
this pull request
Aug 3, 2021
* upstream/master: (23 commits) Use spot instances for E2E on AWS (kubermatic#1310) Add Kubernetes 1.21 presubmits (kubermatic#1312) Add Kubernetes 1.21 binaries to the kubeone-e2e image (kubermatic#1311) [Azure] Added 30 second delay in output so that publicIP for Azure VM is available (kubermatic#1306) Remove e2e build tag (kubermatic#1305) Automate certificates renew (kubermatic#1300) Disable repo_gpgcheck for the Kubernetes yum repo (kubermatic#1304) Unattended upgrades addon (kubermatic#1291) Add the changelog for the v1.2.1 release (kubermatic#1292) Use admissionregistration v1 (kubermatic#1290) Upgrade machinecontroller to v1.27.4 (kubermatic#1288) Install cri-tools on Amazon Linux 2 (kubermatic#1282) Add the changelog for the v1.2.0 release (kubermatic#1275) Upgrade dependencies (kubermatic#1279) Use machinecontroller v1.27.1 to fix issue with flatcar (kubermatic#1276) shfmt (kubermatic#1274) Upgrade machinecontroller to v1.27.0 (kubermatic#1272) Add the changelog for the v1.2.0-rc.1 release (kubermatic#1270) Update E2E tests to use Go 1.16.1 (kubermatic#1268) Update the kubeone-e2e image and build jobs to Go 1.16.1 (kubermatic#1267) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We have quite cool feature in machine-controller "spot instances" flag.
This PR adds a demonstration of how to use it + we save some funds on our e2e tests.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
terraform conversion to string with
format("%t"is needed at otherwise it's treated as real bool and this is an error of json Unmarshal tomap[string]stringDoes this PR introduce a user-facing change?: