[Azure] Added 30 second delay in output so that publicIP for Azure VM is available #1306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubermatic-bot
added
release-note-none
xmudrii
reviewed
Apr 5, 2021
examples/terraform/azure/output.tf
Outdated
| @@ -47,7 +47,7 @@ output "kubeone_workers" { | |||
| # following outputs will be parsed by kubeone and automatically merged into | |||
| # corresponding (by name) worker definition | |||
| "${var.cluster_name}-pool1" = { | |||
| replicas = 1 | |||
| replicas = var.worker_node_vm_count | |||
There was a problem hiding this comment.
This should also be changed to initial_machinedeployment_replicas.
This remove the need of terraform refresh to get publicIP for Azure control_plane VM. Also added variable for machine counts for master and worker nodes Signed-off-by: Vijay Dharap <[email protected]>
Signed-off-by: Vijay Dharap <[email protected]>
…rlier. Signed-off-by: Vijay Dharap <[email protected]>
kron4eg
force-pushed
the
azure_pubip_improvements
branch
from
6089507 to
ddf848c
Compare
kubermatic-bot
added
dco-signoff: yes
kron4eg
approved these changes
Apr 6, 2021
|
LGTM label has been added. Git tree hash: 0f07a6aa9fd99a9251ac710b524a7b4ff3c02282
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dharapvj, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
hwuethrich
added a commit
to hwuethrich/kubeone
that referenced
this pull request
Aug 3, 2021
* upstream/master: (23 commits) Use spot instances for E2E on AWS (kubermatic#1310) Add Kubernetes 1.21 presubmits (kubermatic#1312) Add Kubernetes 1.21 binaries to the kubeone-e2e image (kubermatic#1311) [Azure] Added 30 second delay in output so that publicIP for Azure VM is available (kubermatic#1306) Remove e2e build tag (kubermatic#1305) Automate certificates renew (kubermatic#1300) Disable repo_gpgcheck for the Kubernetes yum repo (kubermatic#1304) Unattended upgrades addon (kubermatic#1291) Add the changelog for the v1.2.1 release (kubermatic#1292) Use admissionregistration v1 (kubermatic#1290) Upgrade machinecontroller to v1.27.4 (kubermatic#1288) Install cri-tools on Amazon Linux 2 (kubermatic#1282) Add the changelog for the v1.2.0 release (kubermatic#1275) Upgrade dependencies (kubermatic#1279) Use machinecontroller v1.27.1 to fix issue with flatcar (kubermatic#1276) shfmt (kubermatic#1274) Upgrade machinecontroller to v1.27.0 (kubermatic#1272) Add the changelog for the v1.2.0-rc.1 release (kubermatic#1270) Update E2E tests to use Go 1.16.1 (kubermatic#1268) Update the kubeone-e2e image and build jobs to Go 1.16.1 (kubermatic#1267) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added variable for machine counts for master and worker nodes
What this PR does / why we need it:
Currently, for Azure, we must always do
terraform refreshto get public IP in the output before we can runkubeone apply. This step is not properly documented and is unnecessary. This PR adds a 30 second delay in finishing the output of terraform and thereby ensures that terraform output ALWAYS contains public ip for control plane VMs.PR also adds variables for count of control plane and worker nodes for easy control of these from variable instead of controlling via terraform files.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):NA
Special notes for your reviewer:
NA
Does this PR introduce a user-facing change?: