Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove e2e build tag #1305

Merged
merged 4 commits into from
Apr 5, 2021
Merged

Remove e2e build tag #1305

merged 4 commits into from
Apr 5, 2021

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Apr 3, 2021

What this PR does / why we need it:

e2e build tag is removed to have more transparent view into test builds from developer local machine PoV. So we could have:

=== RUN   TestClusterConformance
=== RUN   TestClusterConformance/verify_k8s_cluster_deployment_on_AWS
    conformance_test.go:103: set TEST_SET to run this test
=== RUN   TestClusterConformance/verify_k8s_cluster_deployment_on_DO
    conformance_test.go:103: set TEST_SET to run this test
=== RUN   TestClusterConformance/verify_k8s_cluster_deployment_on_Hetzner
    conformance_test.go:103: set TEST_SET to run this test
=== RUN   TestClusterConformance/verify_k8s_cluster_deployment_on_GCE
    conformance_test.go:103: set TEST_SET to run this test
=== RUN   TestClusterConformance/verify_k8s_cluster_deployment_on_Packet
    conformance_test.go:103: set TEST_SET to run this test
=== RUN   TestClusterConformance/verify_k8s_cluster_deployment_on_OpenStack
    conformance_test.go:103: set TEST_SET to run this test
--- PASS: TestClusterConformance (0.00s)
    --- SKIP: TestClusterConformance/verify_k8s_cluster_deployment_on_AWS (0.00s)
    --- SKIP: TestClusterConformance/verify_k8s_cluster_deployment_on_DO (0.00s)
    --- SKIP: TestClusterConformance/verify_k8s_cluster_deployment_on_Hetzner (0.00s)
    --- SKIP: TestClusterConformance/verify_k8s_cluster_deployment_on_GCE (0.00s)
    --- SKIP: TestClusterConformance/verify_k8s_cluster_deployment_on_Packet (0.00s)
    --- SKIP: TestClusterConformance/verify_k8s_cluster_deployment_on_OpenStack (0.00s)
=== RUN   Test_containerRuntimeFlag_Set
=== RUN   Test_containerRuntimeFlag_Set/empty
=== RUN   Test_containerRuntimeFlag_Set/docker
=== RUN   Test_containerRuntimeFlag_Set/containerd
=== RUN   Test_containerRuntimeFlag_Set/gibberish
--- PASS: Test_containerRuntimeFlag_Set (0.00s)
    --- PASS: Test_containerRuntimeFlag_Set/empty (0.00s)
    --- PASS: Test_containerRuntimeFlag_Set/docker (0.00s)
    --- PASS: Test_containerRuntimeFlag_Set/containerd (0.00s)
    --- PASS: Test_containerRuntimeFlag_Set/gibberish (0.00s)
=== RUN   TestClusterUpgrade
=== RUN   TestClusterUpgrade/upgrade_k8s_cluster_on_AWS
    upgrade_test.go:109: set TEST_SET to run this test
=== RUN   TestClusterUpgrade/upgrade_k8s_cluster_on_DO
    upgrade_test.go:109: set TEST_SET to run this test
=== RUN   TestClusterUpgrade/upgrade_k8s_cluster_on_Hetzner
    upgrade_test.go:109: set TEST_SET to run this test
=== RUN   TestClusterUpgrade/upgrade_k8s_cluster_on_GCE
    upgrade_test.go:109: set TEST_SET to run this test
=== RUN   TestClusterUpgrade/upgrade_k8s_cluster_on_Packet
    upgrade_test.go:109: set TEST_SET to run this test
=== RUN   TestClusterUpgrade/upgrade_k8s_cluster_on_OpenStack
    upgrade_test.go:109: set TEST_SET to run this test
--- PASS: TestClusterUpgrade (0.00s)
    --- SKIP: TestClusterUpgrade/upgrade_k8s_cluster_on_AWS (0.00s)
    --- SKIP: TestClusterUpgrade/upgrade_k8s_cluster_on_DO (0.00s)
    --- SKIP: TestClusterUpgrade/upgrade_k8s_cluster_on_Hetzner (0.00s)
    --- SKIP: TestClusterUpgrade/upgrade_k8s_cluster_on_GCE (0.00s)
    --- SKIP: TestClusterUpgrade/upgrade_k8s_cluster_on_Packet (0.00s)
    --- SKIP: TestClusterUpgrade/upgrade_k8s_cluster_on_OpenStack (0.00s)
PASS
ok  	k8c.io/kubeone/test/e2e	(cached)
?   	k8c.io/kubeone/test/e2e/provisioner	[no test files]
=== RUN   TestWithMapEnv
=== RUN   TestWithMapEnv/hash_map_as_env_source
--- PASS: TestWithMapEnv (0.00s)
    --- PASS: TestWithMapEnv/hash_map_as_env_source (0.00s)
PASS
ok  	k8c.io/kubeone/test/e2e/testutil	(cached)

instead of

=== RUN   Test_containerRuntimeFlag_Set
=== RUN   Test_containerRuntimeFlag_Set/empty
=== RUN   Test_containerRuntimeFlag_Set/docker
=== RUN   Test_containerRuntimeFlag_Set/containerd
=== RUN   Test_containerRuntimeFlag_Set/gibberish
--- PASS: Test_containerRuntimeFlag_Set (0.00s)
    --- PASS: Test_containerRuntimeFlag_Set/empty (0.00s)
    --- PASS: Test_containerRuntimeFlag_Set/docker (0.00s)
    --- PASS: Test_containerRuntimeFlag_Set/containerd (0.00s)
    --- PASS: Test_containerRuntimeFlag_Set/gibberish (0.00s)
PASS
ok  	k8c.io/kubeone/test/e2e	(cached)
?   	k8c.io/kubeone/test/e2e/provisioner	[no test files]
=== RUN   TestWithMapEnv
=== RUN   TestWithMapEnv/hash_map_as_env_source
--- PASS: TestWithMapEnv (0.00s)
    --- PASS: TestWithMapEnv/hash_map_as_env_source (0.00s)
PASS
ok  	k8c.io/kubeone/test/e2e/testutil	(cached)

Which of course doesn't represent the actual contents of the ./test.

Does this PR introduce a user-facing change?:

NONE

@kron4eg
Remove e2e build tag
df765ed 
Along with testing.Init() call hack

Signed-off-by: Artiom Diomin <[email protected]>
@kron4eg kron4eg requested a review from xmudrii April 3, 2021 15:41
@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 3, 2021
@kron4eg
Copy link
Member Author

kron4eg commented Apr 3, 2021

/retest

@kubermatic-bot kubermatic-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 5, 2021
@kron4eg
Centralize checking env
8ceb17a 
Signed-off-by: Artiom Diomin <[email protected]>
xmudrii
xmudrii reviewed Apr 5, 2021
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
@kron4eg Please create a PR to update periodics to use the correct environment variables. Besides the question I left, LGTM.

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 5, 2021
xmudrii
xmudrii approved these changes Apr 5, 2021
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ef7c28d3096b7c5c0afeb1052c192b9bc7ce8a23

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xmudrii
Copy link
Member

xmudrii commented Apr 5, 2021

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 5, 2021
@kubermatic-bot kubermatic-bot merged commit 6fa03e1 into master Apr 5, 2021
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.3 milestone Apr 5, 2021
@kubermatic-bot kubermatic-bot deleted the e2e-tag branch April 5, 2021 22:23
hwuethrich added a commit to hwuethrich/kubeone that referenced this pull request Aug 3, 2021
@hwuethrich
Merge remote-tracking branch 'upstream/master'
4a67bf1 
* upstream/master: (23 commits)
  Use spot instances for E2E on AWS (kubermatic#1310)
  Add Kubernetes 1.21 presubmits (kubermatic#1312)
  Add Kubernetes 1.21 binaries to the kubeone-e2e image (kubermatic#1311)
  [Azure] Added 30 second delay in output so that publicIP for Azure VM is available (kubermatic#1306)
  Remove e2e build tag (kubermatic#1305)
  Automate certificates renew (kubermatic#1300)
  Disable repo_gpgcheck for the Kubernetes yum repo (kubermatic#1304)
  Unattended upgrades addon (kubermatic#1291)
  Add the changelog for the v1.2.1 release (kubermatic#1292)
  Use admissionregistration v1 (kubermatic#1290)
  Upgrade machinecontroller to v1.27.4 (kubermatic#1288)
  Install cri-tools on Amazon Linux 2 (kubermatic#1282)
  Add the changelog for the v1.2.0 release (kubermatic#1275)
  Upgrade dependencies (kubermatic#1279)
  Use machinecontroller v1.27.1 to fix issue with flatcar (kubermatic#1276)
  shfmt (kubermatic#1274)
  Upgrade machinecontroller to v1.27.0 (kubermatic#1272)
  Add the changelog for the v1.2.0-rc.1 release (kubermatic#1270)
  Update E2E tests to use Go 1.16.1 (kubermatic#1268)
  Update the kubeone-e2e image and build jobs to Go 1.16.1 (kubermatic#1267)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@kron4eg @kubermatic-bot @xmudrii