🐛 Adjust Tags tab on Application Details Drawer when a Task is running #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Screen shot with the loading text and spinner visible (see the red highlighting): |
When an analysis task is running, and the application drawer is open, show both loading text and spinner and the existing tags. Once the analysis is complete, the loading text/spinner will be removed and any new tags will be shown. Bug-Url: https://issues.redhat.com/browse/MTA-465 Signed-off-by: Scott J Dickerson <[email protected]>
sjd78
force-pushed
the
app-tags-task-running
branch
from
1a7d833 to
f0274e3
Compare
ibolton336
approved these changes
Jul 21, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1191 +/- ##
=======================================
Coverage 44.10% 44.10%
=======================================
Files 177 177
Lines 4501 4501
Branches 1007 1007
=======================================
Hits 1985 1985
Misses 2505 2505
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sjd78
added a commit
to sjd78/tackle2-ui
that referenced
this pull request
Jul 21, 2023
Backport of konveyor#1191 When an analysis task is running, and the application drawer is open, show both loading text and spinner and the existing tags. Once the analysis is complete, the loading text/spinner will be removed and any new tags will be shown. Bug-Url: https://issues.redhat.com/browse/MTA-465 The Reports tab is also mentioned on MTA-465. This was already addressed with konveyor#1103 (backported with konveyor#1190) Signed-off-by: Scott J Dickerson <[email protected]>
sjd78
added a commit
to sjd78/tackle2-ui
that referenced
this pull request
Jul 21, 2023
Backport of konveyor#1191 When an analysis task is running, and the application drawer is open, show both loading text and spinner and the existing tags. Once the analysis is complete, the loading text/spinner will be removed and any new tags will be shown. Bug-Url: https://issues.redhat.com/browse/MTA-465 The Reports tab is also mentioned on MTA-465. This was already addressed with konveyor#1103 (backported with konveyor#1190) Signed-off-by: Scott J Dickerson <[email protected]>
sjd78
added a commit
that referenced
this pull request
Jul 21, 2023
…r when a Task is running (#1192) Backport of #1191 When an analysis task is running, and the application drawer is open, show both loading text and spinner and the existing tags. Once the analysis is complete, the loading text/spinner will be removed and any new tags will be shown. Bug-Url: https://issues.redhat.com/browse/MTA-465 The Reports tab is also mentioned on MTA-465. This was already addressed with #1103 (backported with #1190) Signed-off-by: Scott J Dickerson <[email protected]>
sjd78
added a commit
that referenced
this pull request
Jul 28, 2023
The motivation for this refactoring came while working on #1191 and trying to understand what tasks were given to the analysis table. The select function used by `useFetchTasks()` to filter by addon and to keep only the newest tasks per application id was confusing to read as written. This refactor simplifies the steps involved to use a typical stream processing approach. Output of the refactored function is functionally identical to the original implementation. Signed-off-by: Scott J Dickerson <[email protected]>
This was referenced Nov 22, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an analysis task is running, and the application drawer is open, show both loading text and spinner and the existing tags. Once the analysis is complete, the loading text/spinner will be removed and any new tags will be shown.
Bug-Url: https://issues.redhat.com/browse/MTA-465
The Reports tab is also mentioned on MTA-465. This was already addressed with #1103.