🐛 [backport release-0.2] Always show analysis details in drawer (#1103) #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- It was reported (no bz) that the analysis details should always be accessible from the side drawer. This PR removes the spinner for in-progress analysis status & replaces it with a link to the code viewer modal. Resolves konveyor#1013 - Also, this PR hides the facts tab when no facts are present. Resolves Signed-off-by: ibolton336 <[email protected]>
- Fix CodeEditor modal open/close state when viewing a completed analysis. Signed-off-by: ibolton336 <[email protected]>
ibolton336
changed the title
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## release-0.2 #1190 +/- ##
============================================
Coverage 47.01% 47.01%
============================================
Files 177 177
Lines 4445 4445
Branches 992 992
============================================
Hits 2090 2090
Misses 2341 2341
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sjd78
approved these changes
Jul 21, 2023
sjd78
added a commit
to sjd78/tackle2-ui
that referenced
this pull request
Jul 21, 2023
Backport of konveyor#1191 When an analysis task is running, and the application drawer is open, show both loading text and spinner and the existing tags. Once the analysis is complete, the loading text/spinner will be removed and any new tags will be shown. Bug-Url: https://issues.redhat.com/browse/MTA-465 The Reports tab is also mentioned on MTA-465. This was already addressed with konveyor#1103 (backported with konveyor#1190) Signed-off-by: Scott J Dickerson <[email protected]>
sjd78
added a commit
to sjd78/tackle2-ui
that referenced
this pull request
Jul 21, 2023
Backport of konveyor#1191 When an analysis task is running, and the application drawer is open, show both loading text and spinner and the existing tags. Once the analysis is complete, the loading text/spinner will be removed and any new tags will be shown. Bug-Url: https://issues.redhat.com/browse/MTA-465 The Reports tab is also mentioned on MTA-465. This was already addressed with konveyor#1103 (backported with konveyor#1190) Signed-off-by: Scott J Dickerson <[email protected]>
sjd78
added a commit
that referenced
this pull request
Jul 21, 2023
…r when a Task is running (#1192) Backport of #1191 When an analysis task is running, and the application drawer is open, show both loading text and spinner and the existing tags. Once the analysis is complete, the loading text/spinner will be removed and any new tags will be shown. Bug-Url: https://issues.redhat.com/browse/MTA-465 The Reports tab is also mentioned on MTA-465. This was already addressed with #1103 (backported with #1190) Signed-off-by: Scott J Dickerson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick:
0b20ab3
&&
0ff95b8
Assists with resolving https://issues.redhat.com/browse/MTA-465