🐛 Always show analysis details in drawer #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ibolton336
commented
Jul 10, 2023
•
ibolton336
commented
- It was reported (no bz) that the analysis details should always be accessible from the side drawer. This PR removes the spinner for in-progress analysis status & replaces it with a link to the code viewer modal. Resolves Don't show drawer spinner for ongoing analysis run #1013
- Also, this PR hides the facts tab when no facts are present. Resolves Facts tab shows when no facts are present in the app drawer #1100
|
ibolton336
force-pushed
the
dont-show-spinner
branch
from
816cab3 to
4ad17a7
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1103 +/- ##
==========================================
+ Coverage 44.04% 44.08% +0.03%
==========================================
Files 177 177
Lines 4493 4498 +5
Branches 1007 1007
==========================================
+ Hits 1979 1983 +4
- Misses 2503 2504 +1
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
mturley
requested changes
Jul 10, 2023
| </Button> | ||
| ) : null} | ||
|
|
||
| {notAvailable} |
There was a problem hiding this comment.
This notAvailable should be on the else end of the task ? <Button> : null ternary instead of null, right? Currently you get both the "Analysis details" button and then "not available" text below it (which will always appear).
There was a problem hiding this comment.
Yeah - I was wondering what we should show in this case for the "catch all status". I think your suggestion makes sense.
Signed-off-by: ibolton336 <[email protected]>
ibolton336
force-pushed
the
dont-show-spinner
branch
from
6a5826f to
0e1671c
Compare
ibolton336
added a commit
to ibolton336/tackle2-ui
that referenced
this pull request
Jul 21, 2023
- It was reported (no bz) that the analysis details should always be accessible from the side drawer. This PR removes the spinner for in-progress analysis status & replaces it with a link to the code viewer modal. Resolves konveyor#1013 - Also, this PR hides the facts tab when no facts are present. Resolves Signed-off-by: ibolton336 <[email protected]>
sjd78
added a commit
that referenced
this pull request
Jul 21, 2023
#1191) When an analysis task is running, and the application drawer is open, show both loading text and spinner and the existing tags. Once the analysis is complete, the loading text/spinner will be removed and any new tags will be shown. Bug-Url: https://issues.redhat.com/browse/MTA-465 The Reports tab is also mentioned on MTA-465. This was already addressed with #1103. Signed-off-by: Scott J Dickerson <[email protected]>
ibolton336
added a commit
that referenced
this pull request
Jul 21, 2023
… (#1190) cherry-pick: 0b20ab3 && 0ff95b8 - It was reported (no bz) that the analysis details should always be accessible from the side drawer. This PR removes the spinner for in-progress analysis status & replaces it with a link to the code viewer modal. Resolves #1013 - Also, this PR hides the facts tab when no facts are present. Resolves Assists with resolving https://issues.redhat.com/browse/MTA-465 --------- Signed-off-by: ibolton336 <[email protected]>
sjd78
added a commit
to sjd78/tackle2-ui
that referenced
this pull request
Jul 21, 2023
Backport of konveyor#1191 When an analysis task is running, and the application drawer is open, show both loading text and spinner and the existing tags. Once the analysis is complete, the loading text/spinner will be removed and any new tags will be shown. Bug-Url: https://issues.redhat.com/browse/MTA-465 The Reports tab is also mentioned on MTA-465. This was already addressed with konveyor#1103 (backported with konveyor#1190) Signed-off-by: Scott J Dickerson <[email protected]>
sjd78
added a commit
to sjd78/tackle2-ui
that referenced
this pull request
Jul 21, 2023
Backport of konveyor#1191 When an analysis task is running, and the application drawer is open, show both loading text and spinner and the existing tags. Once the analysis is complete, the loading text/spinner will be removed and any new tags will be shown. Bug-Url: https://issues.redhat.com/browse/MTA-465 The Reports tab is also mentioned on MTA-465. This was already addressed with konveyor#1103 (backported with konveyor#1190) Signed-off-by: Scott J Dickerson <[email protected]>
sjd78
added a commit
that referenced
this pull request
Jul 21, 2023
…r when a Task is running (#1192) Backport of #1191 When an analysis task is running, and the application drawer is open, show both loading text and spinner and the existing tags. Once the analysis is complete, the loading text/spinner will be removed and any new tags will be shown. Bug-Url: https://issues.redhat.com/browse/MTA-465 The Reports tab is also mentioned on MTA-465. This was already addressed with #1103 (backported with #1190) Signed-off-by: Scott J Dickerson <[email protected]>
This was referenced Nov 22, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.