Don't default Revision values when BYO name is unchanged. #13565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
area/API
knative-prow
bot
added
the
approved
Codecov ReportBase: 86.47% // Head: 86.16% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #13565 +/- ##
==========================================
- Coverage 86.47% 86.16% -0.31%
==========================================
Files 196 197 +1
Lines 14600 14672 +72
==========================================
+ Hits 12625 12642 +17
- Misses 1676 1730 +54
- Partials 299 300 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…of hard-coding Configuration and Service.
|
I switched to using a Context-passed |
|
(All three |
|
/retest |
|
(yay, tests pass) |
|
(Reminder, this is blocking #13398 ) |
dprotaso
reviewed
Jan 14, 2023
knative-prow
bot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, evankanderson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
knative-prow
bot
added
lgtm
skonto
pushed a commit
to skonto/serving
that referenced
this pull request
Jan 19, 2023
) * Don't default Revision values when BYO name is unchanged. Fixes knative#11512 * Switch to using a context-passed ConfigurationSpec reference instead of hard-coding Configuration and Service. * Complete docstring for WithConfigurationSpec * Update naming per dave's feedback
openshift-merge-robot
pushed a commit
to openshift-knative/serving
that referenced
this pull request
Jan 19, 2023
) (#131) * Don't default Revision values when BYO name is unchanged. Fixes knative#11512 * Switch to using a context-passed ConfigurationSpec reference instead of hard-coding Configuration and Service. * Complete docstring for WithConfigurationSpec * Update naming per dave's feedback Co-authored-by: Evan Anderson <[email protected]>
skonto
added a commit
to skonto/serving
that referenced
this pull request
Jan 20, 2023
…ative#13565) (knative#131)" This reverts commit f12a329.
skonto
added a commit
to skonto/serving
that referenced
this pull request
Jan 20, 2023
…ged. (knative#13565) (knative#131)"" This reverts commit 81e9cc0.
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/knative-serving
that referenced
this pull request
Mar 8, 2023
) * Don't default Revision values when BYO name is unchanged. Fixes knative#11512 * Switch to using a context-passed ConfigurationSpec reference instead of hard-coding Configuration and Service. * Complete docstring for WithConfigurationSpec * Update naming per dave's feedback
openshift-merge-robot
pushed a commit
to openshift-knative/serving
that referenced
this pull request
Mar 10, 2023
) (#205) * Don't default Revision values when BYO name is unchanged. Fixes knative#11512 * Switch to using a context-passed ConfigurationSpec reference instead of hard-coding Configuration and Service. * Complete docstring for WithConfigurationSpec * Update naming per dave's feedback Co-authored-by: Evan Anderson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11512
Proposed Changes
I wasn't entirely sure how we wanted to handle the fact that the ConfigurationSpec could be embedded in a Service or a Configuration. If we'd prefer, I can smuggle it into and out of the
context, which would make it easier for other projects to interact with Configuration validation. I did the current approach first because it was simpler.Release Note