Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic PR validation #131

Closed
mattmoor opened this issue Feb 10, 2018 · 1 comment
Closed

Basic PR validation #131

mattmoor opened this issue Feb 10, 2018 · 1 comment
Assignees
@adrcunha
Labels
kind/feature Well-understood/specified features, ready for coding.

Comments

@mattmoor
Copy link
Member

I believe the plan is to use Prow, but I'd like to get some basic PR validation in place ASAP to make sure folks aren't breaking unit tests (e.g. I just opened a PR to fix head).

@vaikas-google @adrcunha I'd be happy to throw together a simple Travis setup that we just throw out once Prow's running? :)
@mattmoor mattmoor added the kind/feature Well-understood/specified features, ready for coding. label Feb 10, 2018
@adrcunha adrcunha self-assigned this Feb 11, 2018
@adrcunha
Copy link
Contributor

adrcunha commented Feb 11, 2018 •
edited
Loading

We cannot use Travis CI because the elafros repo is currently private; in order to enable Travis it requires repo write access, which violates Google's policy for OSS projects on Github. Happy to discuss details outside of this bug. Meanwhile, I'll take care of #128 to at least have some documentation about running the tests until Prow is set up.

tcnghia pushed a commit to tcnghia/serving that referenced this issue Jun 8, 2020
@mattmoor
[master] Auto-update dependencies (knative#131)
b5d9707 
Produced via:
  `./hack/update-deps.sh --upgrade && ./hack/update-codegen.sh`
/assign n3wscott shashwathi tanzeeb
/cc n3wscott shashwathi tanzeeb
mgencur referenced this issue in openshift-knative/serving Oct 12, 2022
@openshift-merge-robot
Merge pull request #131 from openshift/markus-istio-0.5.2
0b2f8da 
Update Maistra to 0.10 and disable sidecar injection for 0.5.2.
skonto added a commit to skonto/serving that referenced this issue Jan 19, 2023
@skonto
Don't default Revision values when BYO name is unchanged. (knative#13565
f12a329 
) (knative#131)

* Don't default Revision values when BYO name is unchanged.

Fixes knative#11512

* Switch to using a context-passed ConfigurationSpec reference instead of hard-coding Configuration and Service.

* Complete docstring for WithConfigurationSpec

* Update naming per dave's feedback

Co-authored-by: Evan Anderson <[email protected]>
skonto added a commit to skonto/serving that referenced this issue Jan 20, 2023
@skonto
Revert "Don't default Revision values when BYO name is unchanged. (kn…
81e9cc0 
…ative#13565) (knative#131)"

This reverts commit f12a329.
skonto added a commit to skonto/serving that referenced this issue Jan 20, 2023
@skonto
Revert "Revert "Don't default Revision values when BYO name is unchan…
3107dd0 
…ged. (knative#13565) (knative#131)""

This reverts commit 81e9cc0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adrcunha adrcunha

Labels
kind/feature Well-understood/specified features, ready for coding.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattmoor @adrcunha