[RELEASE-1.7][BACKPORT] Don't default Revision values when BYO name is unchanged. #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skonto
commented
Jan 19, 2023
•
skonto
commented
- Backport of Don't default Revision values when BYO name is unchanged. knative/serving#13565
- Required for the work in [WIP] [RELEASE-1.6][SRVKS-985] Add revision security defaults #68 (SRVKS-985) and for backporting Add secure-pod-defaults flag to default Pods to 'restricted' profile by default knative/serving#13398
- This should allow upgarde tests to pass as discussed in [WIP][SRVKS-934] Enable pod security defaults serverless-operator#1862 (comment)
) * Don't default Revision values when BYO name is unchanged. Fixes knative#11512 * Switch to using a context-passed ConfigurationSpec reference instead of hard-coding Configuration and Service. * Complete docstring for WithConfigurationSpec * Update naming per dave's feedback
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nak3, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@skonto We need to cherry-pick this for 1.8, don't we? |
|
/cherry-pick release-v1.8 |
|
@ReToCode: new pull request created: #205 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.