-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes an issue where the cluster-status-controller overwrites the remedyActions field #5030
fixes an issue where the cluster-status-controller overwrites the remedyActions field #5030
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5030 +/- ##
=======================================
Coverage 28.22% 28.23%
=======================================
Files 632 632
Lines 43431 43435 +4
=======================================
+ Hits 12258 12262 +4
Misses 30278 30278
Partials 895 895
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
431b8d9
to
bd0f584
Compare
bd0f584
to
f2f0a89
Compare
/retest |
9ce54fc
to
6274662
Compare
6274662
to
056dfd0
Compare
a3b294f
to
c7609cf
Compare
c7609cf
to
be537dd
Compare
be537dd
to
7864bac
Compare
/kind bug |
/cc @RainbowMango |
/assign |
Signed-off-by: changzhen <[email protected]>
7864bac
to
d5a317a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…k-of-#5030-upstream-release-1.9 Automated cherry pick of #5030: fix-remedy-e2e-errors
…k-of-#5030-upstream-release-1.10 Automated cherry pick of #5030: fix-remedy-e2e-errors
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
In order to fix the ci error:
https://github.com/karmada-io/karmada/actions/runs/9410947609/job/25923580671
https://github.com/karmada-io/karmada/actions/runs/9413749877/job/25931419319?pr=4986
Root error:
The cluster-status-controller updates cluster status while remedy-controller is updating cluster status,
remedyActions
field is overwritten by the cluster-status-controller.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: