Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #5030: fix-remedy-e2e-errors #5043

Conversation

XiShanYongYe-Chang
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang commented Jun 12, 2024

Cherry pick of #5030 on release-1.10.
#5030: fix-remedy-e2e-errors
For details on the cherry pick process, see the cherry pick requests page.

`karmada-controller-manager`: Fixed an issue that the cluster-status-controller overwrites the remedyActions field.

@karmada-bot karmada-bot requested review from Poor12 and Vacant2333 June 12, 2024 09:01
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 12, 2024
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the automated-cherry-pick-of-#5030-upstream-release-1.10 branch from cd9a5ec to afb0e92 Compare June 13, 2024 01:29
@karmada-bot karmada-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 13, 2024
Signed-off-by: changzhen <[email protected]>
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the automated-cherry-pick-of-#5030-upstream-release-1.10 branch from afb0e92 to fcbc92d Compare June 13, 2024 01:36
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 53.33%. Comparing base (7c13dbb) to head (fcbc92d).

Files Patch % Lines
pkg/controllers/remediation/remedy_controller.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.10    #5043      +/-   ##
================================================
+ Coverage         53.31%   53.33%   +0.01%     
================================================
  Files               253      253              
  Lines             20565    20569       +4     
================================================
+ Hits              10964    10970       +6     
+ Misses             8875     8873       -2     
  Partials            726      726              
Flag Coverage Δ
unittests 53.33% <83.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2024
@karmada-bot karmada-bot merged commit d24cb8e into karmada-io:release-1.10 Jun 13, 2024
12 checks passed
@XiShanYongYe-Chang XiShanYongYe-Chang deleted the automated-cherry-pick-of-#5030-upstream-release-1.10 branch July 13, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants