add more infomation in the remedy-controller

Signed-off-by: changzhen <[email protected]>
karmada-io · Jun 11, 2024 · 431b8d9 · 431b8d9
1 parent 049ddc6
commit 431b8d9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/pkg/controllers/remediation/remedy_controller.go b/pkg/controllers/remediation/remedy_controller.go
@@ -72,11 +72,13 @@ func (c *RemedyController) Reconcile(ctx context.Context, req controllerruntime.
 	actions := calculateActions(clusterRelatedRemedies, cluster)
 	err = retry.RetryOnConflict(retry.DefaultRetry, func() error {
 		if reflect.DeepEqual(actions, cluster.Status.RemedyActions) {
+			klog.V(4).Infof("Ignore to sync cluster(%s) with remedy actions as it has been latest.", cluster.Name)
 			return nil
 		}
 		cluster.Status.RemedyActions = actions
 		updateErr := c.Client.Status().Update(ctx, cluster)
 		if updateErr == nil {
+			klog.V(4).Infof("Success to sync cluster(%s) with remedy actions: %v", cluster.Name, actions)
 			return nil
 		}
 
@@ -93,7 +95,6 @@ func (c *RemedyController) Reconcile(ctx context.Context, req controllerruntime.
 		klog.Errorf("Failed to sync cluster(%s) remedy actions: %v", cluster.Name, err)
 		return controllerruntime.Result{}, err
 	}
-	klog.V(4).Infof("Success to sync cluster(%s) remedy actions", cluster.Name)
 	return controllerruntime.Result{}, nil
 }
 

diff --git a/test/e2e/remedy_test.go b/test/e2e/remedy_test.go
@@ -38,7 +38,7 @@ var _ = framework.SerialDescribe("remedy testing", func() {
 	var remedy *remedyv1alpha1.Remedy
 	var targetCluster string
 
-	ginkgo.Context("remedy.spec.decisionMatches is not empty", func() {
+	framework.SerialContext("remedy.spec.decisionMatches is not empty", func() {
 		ginkgo.BeforeEach(func() {
 			targetCluster = framework.ClusterNames()[0]
 			remedyName = remedyNamePrefix + rand.String(RandomStrLength)
@@ -150,7 +150,7 @@ var _ = framework.SerialDescribe("remedy testing", func() {
 		})
 	})
 
-	ginkgo.Context("test with nil decision matches remedy", func() {
+	framework.SerialContext("test with nil decision matches remedy", func() {
 		ginkgo.BeforeEach(func() {
 			targetCluster = framework.ClusterNames()[0]
 			remedyName = remedyNamePrefix + rand.String(RandomStrLength)