Always runAfterFinalized #462
Conversation
Without this, Notifier#perform runs the Slack message publish code too early, resulting in messages like this: ``` test - jenkinsci#68 Success after 6.9 sec and counting (Open) ``` `isBuilding()` should be true in this instance. Instead, always run the plugin with `runAfterFinalised=true.` This restores the older behavior, (before jenkinsci#361, jenkinsci#125) where SlackListener run the publish code after `isBuilding()` was false and the end message was: ``` test - jenkinsci#80 Success after 6 sec (Open) ```
|
@dshvedchenko can you test your environment with this commit? |
will do tomorrow, pls provide link to build |
Thank you, here it is: correct-publish-time.slack-plugin.zip |
|
job for Success notify with following configs job for success/failur with cuystom success messages
sends only one message job for message on started/on failure sends two messages job that sends onstart/onsuccess
|
|
slack plugin : |
|
@dshvedchenko Thanks for the detailed review! All the results look good and expected to me, did you find any problems with it? |
|
@KreAch3R No issues with FreeStyleJob were found at my configs |
Don't link to build like that, who knows what you put in that zip 😅 When the PR is open there is a HPI uploaded from ci.jenkins.io See: https://ci.jenkins.io/blue/organizations/jenkins/Plugins%2Fslack-plugin/detail/master/97/artifacts |
Without this, Notifier#perform runs the Slack message publish code too early,
resulting in messages like this:
isBuilding()should be true in this instance.Instead, always run the plugin with
runAfterFinalised=true.This restores the older behavior, (before #361, #125) where SlackListener run
the publish code after
isBuilding()was false and the end message was:Refers: #446 (maybe #454) #455 #457