Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slack plugin regression (global slack plugin) #454

Closed
matejsp opened this issue Dec 19, 2018 · 20 comments
Closed

slack plugin regression (global slack plugin) #454

matejsp opened this issue Dec 19, 2018 · 20 comments

Comments

@matejsp
Copy link

matejsp commented Dec 19, 2018

I have just updated to 2.11 and global slack plugin works again! No more exceptions.
However latest version now displays additional "null" text.

Before:
image

After:
image

@timja
Copy link
Member

timja commented Dec 19, 2018

at a guess its this:
#448

@esproul
Copy link

esproul commented Dec 19, 2018

I upgraded to 2.10 yesterday and notifications stopped working. I tried 2.11 this morning and still broken. Downgrading to 2.6 works. I'm running Jenkins 2.156.

I'm not familiar with how to troubleshoot plugin issues but I'm happy to help narrow it down if I can.

@timja
Copy link
Member

timja commented Dec 19, 2018

what's not working? 2.11 should work fine other than the null text

@esproul
Copy link

esproul commented Dec 19, 2018

No notifications are received in Slack. Jenkins appears to have sent them:

Dec 19, 2018 11:10:42 AM jenkins.plugins.slack.SlackNotifier perform
INFO: Performing complete notifications

If I go into a job, under Slack Notifications, and hit Test Connection, I get a message. But there is no notification from any job completion. If I downgrade the plugin, with no other changes, the notifications work.

@matejsp
Copy link
Author

matejsp commented Dec 19, 2018

It works with (with extra null text):
Global Slack Notifier Plugin 1.3
Slack Notification Plugin 2.11
Jenkins ver. 2.156

@timja
Copy link
Member

timja commented Dec 19, 2018

Can you screenshot your global config please? and job config?

@esproul
Copy link

esproul commented Dec 19, 2018

Global settings:
global_settings

Job config:
job_config

@timja
Copy link
Member

timja commented Dec 19, 2018

try remove your slack compatible app url

@esproul
Copy link

esproul commented Dec 19, 2018

Does not appear to make any difference.

@jkrehm
Copy link

jkrehm commented Dec 20, 2018

I am having the same issue after updating to 2.10. Updating to 2.11 did not fix the issue, either. Test Connection works, but jobs do not trigger a message.

@timja
Copy link
Member

timja commented Dec 20, 2018

@jkrehm are you using global slack notifier plugin or just slack-plugin?

@timja
Copy link
Member

timja commented Dec 20, 2018

and what's the last version that works for you @jkrehm ?

@viktorkholod
Copy link

The same issue after upgrade to 2.10 and 2.11.
Jenkins 2.150.1
Slack Notification Plugin 2.11

@timja
Copy link
Member

timja commented Dec 20, 2018

This issue is about null text when used with the global slack notifier plugin

Can you please create a new issue,
and provide your global config and job config, and the last version of the slack plugin that works for you please

@jkrehm
Copy link

jkrehm commented Dec 20, 2018

@timja Just the slack-plugin (I was not aware of the global plugin until this thread).

I upgraded to 2.10 and then 2.11 (hoping it would fix the issue) so I am not able to drop back beyond that, but based on configuration backups, I believe 2.3 was what was in use. I'm guessing that won't be much help diagnosing the issue because of how far back it is.

@timja
Copy link
Member

timja commented Dec 20, 2018

unfortunately not since 2.3 was over a year ago and lots of changes have been merged since.
does your issue look like this one?
#455

I just posted all my config there (which is working for me...) i've been trying to reproduce these issues but not sure what is causing it

@jkrehm
Copy link

jkrehm commented Dec 20, 2018

Since my issue was with slack-plugin (not the global slack-plugin) #457 fixed the issue for me. Please ignore my comments above.

@sergeykranga
Copy link

I had the same issue: upgraded to Jenkins version 2.150.1, slack plugin version 2.11
We use Job DSL to describe/migrate jobs and CasC to configure Slack when newer Jenkins versions appear, so this was not the issue with how jobs/slack was configured.

We never used "Notify regression" option, but I noticed that when you enable it, it starts sending the notifications again. With it disabled, any other combination of options didn't work for me. I looked into the source, and didn't find anything related to this (or maybe I looked in a wrong place). System log also showed no errors.

Solution that worked for me is to upgrade Slack plugin to 2.12, which just recently appeared in plugin manager

@esproul
Copy link

esproul commented Dec 27, 2018

I can also confirm that 2.12 fixes the missing notification. I apologize for hijacking this issue.

To recap: I was running 2.6, which had working notifications. When upgrading to either 2.10 or 2.11, notifications were not sent.

@matejsp
Copy link
Author

matejsp commented Dec 31, 2018

With latest version 2.13 it works without extra null. You can close the issue.

@matejsp matejsp closed this as completed Dec 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants