Fixes issue #125 where this plugin is nested inside another publisher #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 12, 2017
|
I'm highly interested in this PR. What can I do to get it merged quicker? |
ericwengelking
approved these changes
Apr 5, 2018
|
I'm very interested in this as well |
|
Hi, |
|
I'd also love to have this reviewed & merged.... |
|
Really wanting this to be available, when is 2.4 going to be released? |
KreAch3R
added a commit
to KreAch3R/slack-plugin
that referenced
this pull request
Dec 24, 2018
Without this, Notifier#perform runs the Slack message publish code too early, resulting in messages like this: ``` test - jenkinsci#68 Success after 6.9 sec and counting (Open) ``` `isBuilding()` should be true in this instance. Instead, always run the plugin with `runAfterFinalised=true.` This restores the older behavior, (before jenkinsci#361, jenkinsci#125) where SlackListener run the publish code after `isBuilding()` was false and the end message was: ``` test - jenkinsci#80 Success after 6 sec (Open) ```
timja
pushed a commit
that referenced
this pull request
Jan 3, 2019
Without this, Notifier#perform runs the Slack message publish code too early, resulting in messages like this: ``` test - #68 Success after 6.9 sec and counting (Open) ``` `isBuilding()` should be true in this instance. Instead, always run the plugin with `runAfterFinalised=true.` This restores the older behavior, (before #361, #125) where SlackListener run the publish code after `isBuilding()` was false and the end message was: ``` test - #80 Success after 6 sec (Open) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for notifications failing when the Slack publisher is nested within another post-build action such as a conditional action or a template.
Unless I'm missing something it seems unnecessary to have a separate listener for build events outside of the core Notifier implementation. This may simply have been here for legacy reasons, but it makes it difficult to identify which Publisher(s) to run.
I'm going to run a few more tests on this locally in case I'm missing something obvious and breaking anything, but would welcome any comments.