Allow detecting repository on GitHub Enterprise #147
Conversation
Alters the regex that extracts the org/username and repo name from the repo address, so that it can cope with repos that do not exist on github.com (e.g. GitHub Enterprise). Adds a test for this change.
ashmaroli
changed the title
|
In addressing why I was getting local failures (#148) I found that the rspec |
|
I believe the AppVeyor failure is a flake (a failed network connection, perhaps?). Let's ship this as-is, and add further changes in a separate PR? Feel free to ping me directly, @mrmanc. Thank you! @jekyllbot: merge +minor |
|
Awesome, thanks for this. I’ll sort out a separate PR shortly. Apologies for pinging Ben—I thought it best as he’d suggested the fix. I’ll be sure to aim it at you next time :) |
Tests were coupled to a specific origin meaning that tests against forks would fail. I’ve replaced the test that checks the output of `git_remote_url` is okay into a test to check `git_remotes` returns something, and another to check that `git_remote_url` correctly interprets the output from `git_remotes`. I’ve also corrected the test doubles in later tests where (as part of jekyll#147) I had copied an incorrect bit of stubbing of `git_remote_url`. The stubbing appeared to be mimicking `git_remotes` instead. The test seemed to be passing by coincidence before. The stubbed output now matches what the function actually does.
Alters the regex that extracts the org/username and repo name from the repo address based on suggestion by @benbalter, so that it can cope with repos that do not exist on github.com (e.g. GitHub Enterprise).
Adds a test for this change.
Resolves #120