Tests fail when origin changed #148
Labels
Comments
|
@mrmanc Please PR! |
mrmanc
added a commit
to autotraderuk/github-metadata
that referenced
this issue
Jan 4, 2019
Tests were coupled to a specific origin meaning that tests against forks would fail. I’ve replaced the test that checks the output of `git_remote_url` is okay into a test to check `git_remotes` returns something, and another to check that `git_remote_url` correctly interprets the output from `git_remotes`. I’ve also corrected the test doubles in later tests where (as part of jekyll#147) I had copied an incorrect bit of stubbing of `git_remote_url`. The stubbing appeared to be mimicking `git_remotes` instead. The test seemed to be passing by coincidence before. The stubbed output now matches what the function actually does.
|
I believe #152 completed this! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
When the origin remote of a working copy is changed away from
https://github.com/jekyll/github-metadata.git, the tests fail. The failing test contains this assertion:expect(subject.send(:git_remote_url)).to include("jekyll/github-metadata"). This is a head scratcher when running tests before pushing to a fork in preparation for contribution. I have some changes ready to resolve this.The text was updated successfully, but these errors were encountered: