-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
repo detection does not work with github enterprise #120
Comments
It looks like
Regexp.escape(Jekyll::GitHubMetadata::Pages.github_hostname) .
@munkyboy If that's the case, might you be interested in submitting a pull request? |
This issue has been automatically marked as stale because it has not been commented on for at least two months. The resources of the Jekyll team are limited, and so we are asking for your help. If this is a bug and you can still reproduce this error on the If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial. This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions. |
@benbalter I could do with the commit hash for cache busting purposes on a GitHub Enterprise instance. Happy to submit a PR for this, but not sure about the automated test side of it. How would you want me to have tested the change? |
steps to reproduce:
Given a repo has a remote origin of
https://ghe.mycompany.com/proj/repo
PAGES_REPO_NWO
repository
PAGES_GITHUB_HOSTNAME
tohttps://ghe.mycompany.com
running
jekyll serve
fails with error:expected results:
automatic detection of the repo name with owner should support reading from a github enterprise origin. It currently only supports origins of
github.com
https://github.com/jekyll/github-metadata/blob/master/lib/jekyll-github-metadata/repository_finder.rb#L68
The text was updated successfully, but these errors were encountered: