Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

epic: New Thread Settings Panel with correct file overwrites #1044

Closed
7 tasks done
freelerobot opened this issue Dec 16, 2023 · 1 comment
Closed
7 tasks done

epic: New Thread Settings Panel with correct file overwrites #1044

freelerobot opened this issue Dec 16, 2023 · 1 comment
Assignees
Labels
type: epic A major feature or initiative type: feature request A new feature
Milestone

Comments

@freelerobot
Copy link
Contributor

freelerobot commented Dec 16, 2023

Motivation

  • Right panel was missing params / sub sections
  • UI was confusing, because even though Right Panel edits affect thread.json only, users felt like they were editting model.json, assistant.json

Designs

https://www.figma.com/file/ytn1nRZ17FUmJHTlhmZB9f/Jan-App?type=design&node-id=112-37497&mode=design&t=s5Td4SkT9LRH86bS-0

Stories

  1. Users can edit all of the parameters in thread.json except the following:
  • id: show but gray out
  • object: dont show in UI
  • assistants[0] > defaults to Jan (obv this can't be editted)
  • assistants[0].assistant_id: don't show in UI
  • created: don't show in UI
  • updated: don't show in UI
  • metadata: don't show in UI

This might deviate a bit from what's rendered in designs, please follow this guide

  1. Users can refine model configs in the following sections, with changes affecting thread.json
  • Inference parameters
  • Model parameters
  • engine parameters
  1. Remove autosave. Users must click save button.

  2. Basic error handling around users not saving changes in Thread Settings

  3. When users edit the following sections, button must say "save & reload" because it requires models to be reloaded at nitro level. Otherwise, button just says "save"

  • Model params
  • Engine params
  1. Sections have tooltips:
  1. Change the Assistant & Model section Dropdowns to "edit global defaults for [model/assistant name]" rather than what we had before. See designs.

  2. If users edit assistant.json, or model.json directly, the overwrites take effect for subsequent new threads

Tasklist

Not in Scope

@freelerobot freelerobot added the type: feature request A new feature label Dec 16, 2023
@freelerobot freelerobot added P0: critical Mission critical and removed P0: critical Mission critical labels Dec 16, 2023
@freelerobot freelerobot modified the milestones: Jan December Launch, Jan as the Default Assistant Dec 18, 2023
@freelerobot freelerobot moved this to Triaged (Backlog) in Menlo Dec 18, 2023
@dan-menlo dan-menlo changed the title feat: thread right panel has model and engine parameters epic: thread right panel has model and engine parameters Dec 20, 2023
@dan-menlo dan-menlo added the type: epic A major feature or initiative label Dec 20, 2023
@dan-menlo dan-menlo changed the title epic: thread right panel has model and engine parameters epic: Thread right panel has model and engine parameters Dec 20, 2023
@namchuai namchuai moved this from Icebox to Planned in Menlo Dec 25, 2023
@namchuai namchuai moved this from Planned to In Progress in Menlo Dec 25, 2023
@freelerobot freelerobot removed this from the Jan as the Default Assistant milestone Dec 27, 2023
@freelerobot freelerobot changed the title epic: Thread right panel has model and engine parameters epic: Thread right panel - new UX, renders all params, and does correct overwrites Dec 27, 2023
@freelerobot freelerobot added this to the v0.4.5 milestone Dec 27, 2023
@freelerobot freelerobot changed the title epic: Thread right panel - new UX, renders all params, and does correct overwrites epic: New hreads right panel with correct file overwrites Dec 27, 2023
@freelerobot freelerobot changed the title epic: New hreads right panel with correct file overwrites epic: New Thread Settings Panel with correct file overwrites Dec 27, 2023
@freelerobot freelerobot moved this from In Progress to Planned in Menlo Dec 29, 2023
@imtuyethan imtuyethan modified the milestones: v0.4.5, v0.4.4 Jan 4, 2024
@freelerobot
Copy link
Contributor Author

Closing this epic, other than a dangling QA issue.

Great job @namchuai

@github-project-automation github-project-automation bot moved this from Planned to Done in Menlo Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: epic A major feature or initiative type: feature request A new feature
Projects
Archived in project
Development

No branches or pull requests

4 participants