Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: thread.json not automatically updated before clicking send button #1212

Closed
Tracked by #1044
0xHieu01 opened this issue Dec 26, 2023 · 6 comments
Closed
Tracked by #1044
Assignees
Labels
P1: important Important feature / fix type: bug Something isn't working

Comments

@0xHieu01
Copy link
Contributor

0xHieu01 commented Dec 26, 2023

Describe the bug
thread.json not automatically updated before clicking send button

Steps to reproduce
Steps to reproduce the behavior:

  1. As an user, I modified thread title, assistant instruction.
  2. Then, I selected the model.
  3. Due to the thread.json not automatically updated, after I selected the model, all typed input are automatically reset to default.
  4. Therefore, user need to retype the thread title and assistant instruction after selecting model.

Expected behavior
As a discussion in the meeting with @0xSage, we currently expect that the thread.json is automatically generated and updated when user doing any action like type an input to thread title, assistant instruction or selecting model. Thus, when users selecting the model, it's should be remain the same thread title and assistant instruction as thread.json is already created.

Screenshots
GIF will need few minutes for loading

jan-bug

Environment details

  • Operating System: MacOS Sonoma 14.2.1
  • Jan Version: 0.4.3
  • Processor: Apple M1 Pro
  • RAM: 16GB

Additional context
Add any other context or information that could be helpful in diagnosing the problem.

@0xHieu01 0xHieu01 added the type: bug Something isn't working label Dec 26, 2023
@freelerobot
Copy link
Contributor

@hieu-jan I'd rephrase the bug to be clearer.

Expected:

  • Create thread.json file as soon as user clicks New Thread
  • This way, thread settings changes are saved to the New Thread
  • Even if users haven't sent any messages in thread.

Current:

  • User clicks New Thread
  • New thread is created in UI only
  • User makes changes to thread.json in right panel UI
  • User expects changes to be saved.
  • But changes are not saved to thread.json
  • Changes are only saved after user sends a message

We expect this to be a common UX and it needs to be handled. Users are highly likely to configure parameters first, before sending their first message.

@louis-jan
Copy link
Contributor

Thanks for the clarification. That makes sense, will fix this.

@louis-jan louis-jan moved this to In Progress in Menlo Dec 27, 2023
@louis-jan louis-jan moved this from In Progress to In Review in Menlo Dec 27, 2023
@louis-jan louis-jan moved this from In Review to In Progress in Menlo Dec 27, 2023
@louis-jan
Copy link
Contributor

With the latest UX update from @urmauur, users will always have to click 'Save'; otherwise, an error popup will appear. cmiiw @urmauur

@louis-jan louis-jan moved this from In Progress to In Review in Menlo Jan 2, 2024
@louis-jan louis-jan moved this from In Review to In Progress in Menlo Jan 3, 2024
@freelerobot freelerobot added the wontfix This will not be worked on label Jan 5, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Menlo Jan 5, 2024
@Van-QA
Copy link
Contributor

Van-QA commented Jan 9, 2024

As discussed with @louis-jan, the Save button is no longer available, so we will need the thread.json to be automatically created / updated on any changes.

@Van-QA Van-QA reopened this Jan 9, 2024
@Van-QA Van-QA added P1: important Important feature / fix and removed wontfix This will not be worked on labels Jan 12, 2024
@Van-QA Van-QA removed the status in Menlo Jan 12, 2024
@namchuai namchuai self-assigned this Jan 12, 2024
@namchuai namchuai moved this to Planned in Menlo Jan 14, 2024
@namchuai namchuai moved this from Planned to In Progress in Menlo Jan 14, 2024
namchuai added a commit that referenced this issue Jan 14, 2024
@namchuai namchuai moved this from In Progress to In Review in Menlo Jan 14, 2024
namchuai added a commit that referenced this issue Jan 14, 2024
@namchuai
Copy link
Collaborator

This is issue is fixed with PR #1570 . Please help to verify it. Thank you!

@freelerobot
Copy link
Contributor

Fixed as of nightly, patch no. 143

@github-project-automation github-project-automation bot moved this from In Review to Done in Menlo Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1: important Important feature / fix type: bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

5 participants