Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new threads should default to previous threads configurations #1175

Closed
dillfrescott opened this issue Dec 22, 2023 · 4 comments
Closed
Assignees
Labels
P1: important Important feature / fix type: feature request A new feature
Milestone

Comments

@dillfrescott
Copy link

I am always sliding the slider to 4096 tokens every new chat from the default. It should 100% remember what you set it to and persist.

@freelerobot
Copy link
Contributor

freelerobot commented Dec 26, 2023

Threads should indeed default to the same settings as the previous thread.json

Discussion in progress:

Right now, we hardcoded model parameter defaults for thread.json, when model params should inherit from assistants (which inherits from models)

(1) First time ever that you chat with a model.

  • model configs should default to assistant.model.param settings
  • if assistant.json missing model.params, then default to model.json settings.

(2) Starting a new thread with existing chat history

Option a) default to previous thread configs thread.json
Option b) default to assistant defaults (which default to model defaults)

I prefer (a)

@freelerobot freelerobot changed the title Token count slider should remember the setting between chats feat: new threads should default to previous threads configurations Dec 26, 2023
@freelerobot freelerobot moved this to Planned in Menlo Dec 26, 2023
@imtuyethan
Copy link
Contributor

I will include this issue to epic: #1507

@freelerobot
Copy link
Contributor

freelerobot commented Jan 23, 2024 via email

@namchuai namchuai moved this from Planned to In Progress in Menlo Apr 3, 2024
@louis-jan louis-jan removed their assignment Apr 5, 2024
@louis-jan louis-jan moved this from In Progress to Planned in Menlo Apr 26, 2024
@Van-QA
Copy link
Contributor

Van-QA commented May 28, 2024

Need Co‌‌rtex support as in https://github.com/janhq/cortex/issues/617

@freelerobot freelerobot added the P1: important Important feature / fix label Jun 11, 2024
@Van-QA Van-QA moved this from Planned to In Progress in Menlo Jul 1, 2024
@Van-QA Van-QA moved this from In Progress to Planned in Menlo Jul 1, 2024
@Van-QA Van-QA added this to the v.0.6.0 milestone Aug 5, 2024
@Van-QA Van-QA closed this as completed Aug 5, 2024
@github-project-automation github-project-automation bot moved this from Planned to Done in Menlo Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1: important Important feature / fix type: feature request A new feature
Projects
Archived in project
Development

No branches or pull requests

7 participants