Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Reveal in Finder does not work in Windows, it has wrong slashes in the dir path #1183

Closed
Tracked by #1044
linkinxp opened this issue Dec 24, 2023 · 1 comment · Fixed by #1239
Closed
Tracked by #1044

bug: Reveal in Finder does not work in Windows, it has wrong slashes in the dir path #1183

linkinxp opened this issue Dec 24, 2023 · 1 comment · Fixed by #1239
Assignees
@namchuai
Labels
type: bug Something isn't working

Comments

@linkinxp
Copy link

Describe the bug
Clicking on Reveal in Finder does not work, throws and error saying that it can't find, if you look at the path is trying to go, it has backwards slashes

To Reproduce
Steps to reproduce the behavior:

  1. Go to 3 dots next to thread
  2. Click on Reveal in inder
  3. See error

Expected behavior
I would expect windows explorer would open to the right directory

Screenshots
image
Correct Path:
image

Desktop (please complete the following information):

  • OS: Windows 11 Pro
  • Version 0.4.3
@linkinxp linkinxp added the type: bug Something isn't working label Dec 24, 2023
@dan-menlo
Copy link
Contributor

Ah man, our bad! You can guess what OS the Jan Team prefers ;)

@freelerobot freelerobot moved this to Planned in Menlo Dec 26, 2023
@freelerobot freelerobot mentioned this issue Dec 27, 2023
Closed
7 tasks
@hiento09 hiento09 moved this from Planned to In Progress in Menlo Dec 28, 2023
namchuai pushed a commit that referenced this issue Dec 28, 2023
fix(OpenFile): #1183 reveal in finder does not work on windows
dfcf44d 
Signed-off-by: James <[email protected]>
@namchuai namchuai mentioned this issue Dec 28, 2023
Merged
@hiento09 hiento09 assigned namchuai and unassigned hiento09 Dec 28, 2023
@namchuai namchuai moved this from In Progress to In Review in Menlo Dec 28, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Menlo Dec 28, 2023
namchuai added a commit that referenced this issue Dec 28, 2023
@namchuai
fix: #1183 Reveal in finder does not work on windows (#1239)
cbc63da 
* fix(OpenFile): #1183 reveal in finder does not work on windows

Signed-off-by: James <[email protected]>
---------

Signed-off-by: James <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@namchuai namchuai

Labels
type: bug Something isn't working
Projects
Menlo
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: #1183 Reveal in finder does not work on windows janhq/jan
5 participants
@namchuai @linkinxp @freelerobot @dan-menlo @hiento09