-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor of the filter-panel #165
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #131 and closes #142 and closes #161 and closes #162 Co-authored-by: Dawid Kałędkowski <[email protected]>
Unit Test Performance Difference
Additional test case details
Results for commit d218074 ♻️ This comment has been updated with latest results. |
Merging `main` branch into `filter_panel_refactor` following #189. --------- Co-authored-by: chlebowa <[email protected]> Co-authored-by: Dawid Kałędkowski <[email protected]>
Allows filter state inputs to collapse and expand, defaulting to collapsed. Only 1 filter state per data set can be open at a time. - For a given data set, filter information is in an accordion of collapsible cards - Only 1 filter state (per data set) can be open at a time. - Card headers show a summary of the filter state. Logical and choices filter state UIs don't display correctly, at least on Bootstrap 4. Closes #129. --------- Co-authored-by: Dawid Kałędkowski <[email protected]>
# Pull Request Fixes #[183](#183) --------- Signed-off-by: Marek Blazewicz <[email protected]> Co-authored-by: Mahmoud Hallal <[email protected]> Co-authored-by: Dawid Kałędkowski <[email protected]>
# Pull Request Fixes #[158](#158) 1. At initialization, when values are not valid, corrections will be performed with warnings. 2. Later, when changed by the user, shinyvalidate is used. Example to test: ``` adsl <- synthetic_cdisc_dataset("latest", "adsl") app <- init( data = teal_data(dataset("ADSL", adsl)), modules = example_module(), filter = list( "ADSL" = list( RANDDT = list(selected = c("2021-02-16", "2021-02-17")), TRT01SDTM = list(selected = c("2021-02-11 17:09:18", "2021-02-10 20:42:27")) ) ) ) runApp(app) ``` --------- Signed-off-by: Marek Blazewicz <[email protected]> Co-authored-by: Dawid Kałędkowski <[email protected]>
Merged
fix #371 --------- Co-authored-by: Dawid Kałędkowski <[email protected]>
rename and docs fixing
Closes #378 This PR provides an ability to pass `trim_lines` parameter for `$format()` method of FilterState, FilerStates, FilteredDataset and FilteredData R6 objects. --------- Signed-off-by: Marcin <[email protected]> Co-authored-by: Aleksander Chlebowski <[email protected]> Co-authored-by: 27856297+dependabot-preview[bot]@users.noreply.github.com <27856297+dependabot-preview[bot]@users.noreply.github.com>
Code Coverage Summary
Diff against main
Results for commit: d58f998 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
- deprecate unused - update authors
This was referenced Jul 12, 2023
closes #52 --------- Co-authored-by: Aleksander Chlebowski <[email protected]> Co-authored-by: 27856297+dependabot-preview[bot]@users.noreply.github.com <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: m7pr <[email protected]>
chlebowa
approved these changes
Jul 14, 2023
gogonzo
added a commit
to insightsengineering/teal.gallery
that referenced
this pull request
Jul 14, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature branch for recent changes related with refactor of the filter-panel
Todo before merge:
teal.slice
documentation on refactor branch #337testing module
MAE example
CDISC example
non-cdisc example