You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think these get_choices_label functions are too complicated. I think we can simplify and tidy up the way how we obtain counts. In the init of choicesFilterState there is private$histogram_data which isn't used at all. Having private$choices where value is a factor level and name is a count is also not elegant. I think we can introduce
I think these
get_choices_label
functions are too complicated. I think we can simplify and tidy up the way how we obtain counts. In the init ofchoicesFilterState
there isprivate$histogram_data
which isn't used at all. Havingprivate$choices
where value is a factor level and name is a count is also not elegant. I think we can introduceThat is just a proposition, I think it would be nice if we tidy up these
initialize
methods and how we preserve counts.Originally posted by @gogonzo in #180 (comment)
The text was updated successfully, but these errors were encountered: