Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS good practices #563

Closed
chlebowa opened this issue Mar 4, 2024 · 3 comments
Closed

CSS good practices #563

chlebowa opened this issue Mar 4, 2024 · 3 comments
Labels
core question Further information is requested

Comments

@chlebowa
Copy link
Contributor

chlebowa commented Mar 4, 2024

Our CSS file includes multiple expressions like this:
color: var(--bs-body-color, #333333);
background-color: var(--bs-gray-200, #e9ecef);

Is overwriting theme colors the proper way to style our elements? Why are we replacing variable values with hard coded values? Should we not rather use the hard coded values directly?
@chlebowa chlebowa added question Further information is requested core labels Mar 4, 2024
@donyunardi
Copy link
Contributor

bs are custom css values in Bootstrap so if I think this setup automatically change the UI colors for filter panel if they choose to use different Bootstrap themes.

It was added in #165 so maybe @gogonzo can confirm.

@chlebowa
Copy link
Contributor Author

chlebowa commented Mar 7, 2024

I don't think he will, styling was an afterthought in that PR 😆

@chlebowa
Copy link
Contributor Author

I just realized I misunderstood the var function. Sorry for raising a ruckus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@donyunardi @chlebowa