Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've broken out the commits to hopefully make it easier for review.
Closes #485
3f2f097, 9fb0ea3
image
0.24 removes theBgr
andBgra
pixel types image-rs/image#1482'static
was largely removed from traits and impl bounds so it's removed here image-rs/image#1597e501161
Main bulk of changes for migration work
Some trait bounds needed to be added to
src/integral_image.rs
andsrc/map.rs
functions since a sealed traitEnlargeable
was added to theRgb
/Rgba
definitions image-rs/image#1651The following seems to satisfy the requirements.
2a3c5c0
GenericImage::get_pixel_mut
is deprecated in 0.24 so I've replaced the two occurrences of it.61f4863
Replaced regression truth image files.
4 regression tests failed likely due to changes made in
Luma
calculation to minimize floating point errors image-rs/image#1214.The failure error output can be read below in the contracted view. The differences are fairly small.
27 of the files changed are truth files from regression tests being regenerated. In
test_match_histograms
, the center pixel at (177, 170) doesn't match.Failed regression tests
cf3bec1
I noticed that I added the bound but it wasn't needed due to
Enlargeable
not being added to the Luma color define macro definitions inimage
.