Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to image 0.24 #485

Closed
vadixidav opened this issue Feb 3, 2022 · 3 comments · Fixed by #491
Closed

Update to image 0.24 #485

vadixidav opened this issue Feb 3, 2022 · 3 comments · Fixed by #491

Comments

@vadixidav
Copy link

This crate seems to be out of date with image (including on master).

@laris
Copy link

laris commented Feb 11, 2022

error[E0308]: mismatched types
  --> src/main.rs:89:15
   |
89 |     threshold(&img_luma, 230);
   |               ^^^^^^^^^ expected struct `image::buffer_::ImageBuffer`, found struct `ImageBuffer`
   |
   = note: expected reference `&image::buffer_::ImageBuffer<image::color::Luma<u8>, Vec<u8>>`
              found reference `&ImageBuffer<Luma<u8>, Vec<u8>>`
   = note: perhaps two different versions of crate `image` are being used?

For more information about this error, try `rustc --explain E0308`.

@laris
Copy link

laris commented Feb 14, 2022

Could consider to upgrade to the dependent to image 0.24?
some API of image was changed.

pub fn crop(&mut self, x: u32, y: u32, width: u32, height: u32) -> DynamicImage
Return a cut-out of this image delimited by the bounding rectangle.

Note: this method does not modify the object, and its signature will be replaced with crop_imm()’s in the 0.24 release

@OvermindDL1
Copy link

The newer image also has some new functionality that did not exist before so backdating to use imageproc loses that capability as well.

Is someone making a PR for this or where is it being worked on? Is there some blocker?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants