Remove 'static bound from traits and impls #1597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'from traits' part is the breaking change. Downstream consumers could have previously made use of this additional bound. This is not required, we never utilize types `&'static [Subpixel]` or similar and if we would then it could be a local bound. But the bound is infectious in that it requires placing several additional bounds in every place where the `Pixel` trait is being used.
fintelia
approved these changes
Nov 1, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'from traits' part is the breaking change. Downstream consumers
could have previously made use of this additional bound.
This is not required, we never utilize types
&'static [Subpixel]orsimilar and if we would then it could be a local bound. But the bound is
infectious in that it requires placing several additional bounds in
every place where the
Pixeltrait is being used.This does not clean up all usage sites (in
imageops).