Issue 1466 #1596
Merged
Issue 1466 #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r those image formats that have an alpha channel
…etime bounds have been removed from the traits and are no longer required to be specified
HeroicKatora
approved these changes
Nov 1, 2021
fintelia
approved these changes
Nov 1, 2021
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for DynamicImage::grayscale not preserving the alpha channel for input images that have an alpha channel. Fixes issue #1466
[src/imageops/colorops.rs]
Made new functions grayscale_alpha and grayscale_with_type_alpha which do the same as their non-alpha counterparts except they preserve the alpha channel
Uses LumaA rather than Luma for the pixel type
Uses .to_luma_alpha() rather than .to_luma()
[src/imageops/mod.rs]
Expose the new functions from the imageops module so we can access them in src/dynimage.rs
[src/dynimage.rs]
Updated DynamicImage::grayscale method to use grayscale_alpha/grayscale_with_type_alpha instead of the non-alpha counterparts when the input format has an alpha channel
Added tests to ensure that the alpha channel is discarded/preserved appropriately based on the input format