Skip to content
This repository has been archived by the owner on Dec 7, 2021. It is now read-only.

Add effective dates to Service Alerts #136

Closed
msrichardson opened this issue Oct 25, 2018 · 1 comment · Fixed by opentripplanner/otp-react-redux#94 or opentripplanner/otp-react-redux#102
Assignees

Comments

@msrichardson
Copy link
Collaborator

msrichardson commented Oct 25, 2018

Please add the effective date to the end of each service alert (see below for examples). [The effective start date is included in the OTP response.]

croppercapture 332

@landonreed
Copy link
Contributor

The "Effective as of" text was added some time ago. However, a continuation of this issue is that @msrichardson has found cases where the string reads Effective as of Last Tuesday rather than simply using the calendar format.

The source appears to be an incorrect use of moment here:

https://github.com/opentripplanner/otp-react-redux/blob/13061968d9cdb18fae34e545a2ebce8ac72d803d/lib/components/narrative/line-itin/transit-leg-body.js#L212-L217

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants