Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix date string display in service alert #94

Merged
merged 2 commits into from
Aug 13, 2019
Merged

Conversation

landonreed
Copy link
Member

Use the correct moment method to format date string.

Fix ibi-group/trimet-mod-otp#136.

@codecov-io
Copy link

codecov-io commented Aug 12, 2019

Codecov Report

Merging #94 into dev will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff          @@
##             dev     #94   +/-   ##
=====================================
  Coverage   10.2%   10.2%           
=====================================
  Files        134     134           
  Lines       5999    5999           
  Branches    1733    1733           
=====================================
  Hits         612     612           
  Misses      4567    4567           
  Partials     820     820
Impacted Files Coverage Δ
...components/narrative/line-itin/transit-leg-body.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1306196...af96520. Read the comment docs.

@landonreed landonreed merged commit d62485d into dev Aug 13, 2019
@evansiroky evansiroky mentioned this pull request Aug 13, 2019
@evansiroky
Copy link
Contributor

🎉 This PR is included in version 0.12.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@msrichardson
Copy link

msrichardson commented Aug 15, 2019

To clarify, if service alert effective date is anything other than yesterday/today/tomorrow (or now +/- one day), please use the actual date (ex: Effective as of August 6, 2019). If yesterday/today/tomorrow (now +/- one day), please use that language (ex: Effective as of 2:33 pm today). [We don't anticipate ever having a 'tomorrow', but wanted to include that possibility for other entities.]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add effective dates to Service Alerts
4 participants