refactor(transit-leg-body): fix alert effective time

Use relative terms for Today/Yesterday ref ibi-group/trimet-mod-otp#136
opentripplanner · Aug 13, 2019 · d9b7c96 · d9b7c96
1 parent 9e1a1ba
commit d9b7c96
Showing 1 changed file with 11 additions and 8 deletions.
diff --git a/lib/components/narrative/line-itin/transit-leg-body.js b/lib/components/narrative/line-itin/transit-leg-body.js
@@ -202,14 +202,17 @@ class AlertsBody extends Component {
         {this.props.alerts
           .sort((a, b) => b.effectiveStartDate - a.effectiveStartDate)
           .map((alert, i) => {
-            const effectiveStartDate = moment(alert.effectiveStartDate)
-            const daysAway = moment().diff(effectiveStartDate, 'days')
-            // Add time if alert is effective within one day. Otherwise, use
-            // calendar long date format (e.g., July 31, 2019).
-            const dateTimeFormat = Math.abs(daysAway) <= 1
-              ? `${timeFormat}, ${longDateFormat}`
-              : longDateFormat
-            const dateTimeString = effectiveStartDate.format(dateTimeFormat)
+            // Add time  (with Today/Yesterday) if alert is effective within one
+            // day. Otherwise, use calendar long date format (e.g., July 31, 2019).
+            // Note: this does not account for the format for future alert
+            // effective start dates.
+            const dateTimeString = moment(alert.effectiveStartDate)
+              .calendar(null, {
+                sameDay: `${timeFormat}, [Today]`,
+                lastDay: `${timeFormat}, [Yesterday]`,
+                lastWeek: longDateFormat,
+                sameElse: longDateFormat
+              })
             const effectiveDateString = `Effective as of ${dateTimeString}`
             return (
               <div key={i} className='transit-alert'>