-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formalize holidays and time off policy #120
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and LGTM! Thanks for much, @dcwalk :)
Some but not all canada.ca links are failing. As per gjtorikian/html-proofer#131 (comment), how about we dial down concurrency here, and see if that reduces these annoying errors errors: Lines 6 to 10 in 45d354e
EDIT: the 3 canada.ca fails went away after a re-run, but I think we should still do it. Gonna push a change since I'm already on CLI and it's easy :) |
Hm. Still not working. Will try a quick fix when i get back on compy in 30 min, or otherwise will revert back to unforked html-proofer (you're welcome to do same) |
ok fixed :) |
Just the list of holiday dates to work from for calendar: Ontario Family Day Good Friday May Day (International Workers' Day) Victoria Day Canada Day Civic Holiday Labour Day Thanksgiving Remembrance Day Christmas Day Boxing Day |
We should consider Earth Day apparently (April 22). |
Consensed / confirmed this was our policy at 2021-04-07 all hands |
gem "html-proofer", | ||
# Temporary fork to allow concurrency to be set via CLI. | ||
# See: https://github.com/gjtorikian/html-proofer/pull/632 | ||
github: "patcon/html-proofer", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel a little cautious about this approach
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, def remove it then. i've shared my logic, and totes your call
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait, no, i thought this was something else.
Sorry, why feeling cautious? This is the self-documenting way I understand folks use package managers when waiting for upstream changes to get merged, and i'm not sure how else one goes about it... waiting on upstream to merge months later is not an approach I'm familiar with. Would forking to hyphacoop org feel more solid?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to hold off a bit longer, it will prob be merged in the next week: gjtorikian/html-proofer#632 (comment)
But merging stuff like this from in-process forks is totally par for the course in past positions I've worked at, and isn't usually considered a "code smell". It's just a house-keeping task to go through the manifest file every few months or so and sweep forks back to mainline or poke PR's along :)
This was in our business plan, and this is the time off policy we've been working with around office closures and notification.
Prompted because we almost missed another holiday again? This shouldn't be merged until discussed at all hands, but codifies existing practices and comments from our business strategy.
Once approved I will update our calendar and merge