Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formalize holidays and time off policy #120

Merged
merged 10 commits into from
Apr 8, 2021
Merged

Formalize holidays and time off policy #120

merged 10 commits into from
Apr 8, 2021

Conversation

dcwalk
Copy link
Contributor

@dcwalk dcwalk commented Mar 29, 2021

This was in our business plan, and this is the time off policy we've been working with around office closures and notification.

Prompted because we almost missed another holiday again? This shouldn't be merged until discussed at all hands, but codifies existing practices and comments from our business strategy.

Once approved I will update our calendar and merge

@patcon patcon temporarily deployed to hypha-handbo-add-time-o-ivaqvh March 29, 2021 14:34 Inactive
@patcon patcon had a problem deploying to hypha-handbo-add-time-o-pjkegh March 29, 2021 14:45 Failure
@patcon patcon temporarily deployed to hypha-handbo-add-time-o-pjkegh March 29, 2021 14:48 Inactive
@dcwalk dcwalk requested review from benhylau and patcon March 29, 2021 14:49
@patcon patcon temporarily deployed to hypha-handbo-add-time-o-bcg1xp March 29, 2021 14:52 Inactive
Copy link
Contributor

@patcon patcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and LGTM! Thanks for much, @dcwalk :)

@patcon
Copy link
Contributor

patcon commented Mar 29, 2021

Some but not all canada.ca links are failing. As per gjtorikian/html-proofer#131 (comment), how about we dial down concurrency here, and see if that reduces these annoying errors errors:

handbook/Makefile

Lines 6 to 10 in 45d354e

$(RUN) htmlproofer ./_book \
--allow-hash-href \
--check-html \
--typhoeus-config '{ "timeout": $(TIMEOUT), "connecttimeout": $(TIMEOUT) }' \
--url-ignore "/github.com\/hyphacoop\/organizing-private/,/github.com\/issues/"

EDIT: the 3 canada.ca fails went away after a re-run, but I think we should still do it. Gonna push a change since I'm already on CLI and it's easy :)

@patcon patcon temporarily deployed to hypha-handbo-add-time-o-6kfszo March 29, 2021 20:17 Inactive
@patcon patcon temporarily deployed to hypha-handbo-add-time-o-cis92r March 29, 2021 20:18 Inactive
@patcon patcon temporarily deployed to hypha-handbo-add-time-o-xcxoj3 March 29, 2021 20:24 Inactive
@patcon
Copy link
Contributor

patcon commented Mar 29, 2021

Hm. Still not working. Will try a quick fix when i get back on compy in 30 min, or otherwise will revert back to unforked html-proofer (you're welcome to do same)

@patcon patcon temporarily deployed to hypha-handbo-add-time-o-r4gfhh March 29, 2021 21:48 Inactive
@patcon patcon temporarily deployed to hypha-handbo-add-time-o-ls1ht8 March 29, 2021 21:48 Inactive
@patcon patcon temporarily deployed to hypha-handbo-add-time-o-kr2ydj March 29, 2021 21:49 Inactive
@patcon patcon temporarily deployed to hypha-handbo-add-time-o-rnbteh March 29, 2021 21:51 Inactive
@patcon
Copy link
Contributor

patcon commented Mar 29, 2021

ok fixed :)

@patcon patcon temporarily deployed to hypha-handbo-add-time-o-uvjw5k March 29, 2021 21:58 Inactive
@patcon patcon temporarily deployed to hypha-handbo-add-time-o-w6nuyg March 29, 2021 22:00 Inactive
@dcwalk
Copy link
Contributor Author

dcwalk commented Mar 30, 2021

Just the list of holiday dates to work from for calendar:
Holiday 2020 2021 202
New Year's Day
January 1
Wed, January 1
Fri, January 1
Sat, January 1

Ontario Family Day
Third Monday in February
Mon, February 17
Mon, February 15
Mon, February 21

Good Friday
Friday before Easter Sunday
Fri, April 10
Fri, April 2
Fri, April 15

May Day (International Workers' Day)
May 1
Friday, May 1
Saturday, May 1
Sunday, May 1

Victoria Day
Monday before May 25
Mon, May 18
Mon, May 24
Mon, May 23

Canada Day
July 1
Wed, July 1
Thu, July 1
Fri, July 1

Civic Holiday
First Monday in August
Mon, August 3
Mon, August 2
Mon, August 1

Labour Day
First Monday in September
Mon, September 7
Mon, September 6
Mon, September 5

Thanksgiving
Second Monday in October
Mon, October 12
Mon, October 11
Mon, October 10

Remembrance Day
November 11
Wed, November 11
Thu, November 11
Fri, November 11

Christmas Day
December 25
Fri, December 25
Sat, December 25
Sun, December 25

Boxing Day
December 26
Sat, December 26
Sun, December 26
Mon, December 26

@dcwalk
Copy link
Contributor Author

dcwalk commented Apr 8, 2021

We should consider Earth Day apparently (April 22).

@dcwalk
Copy link
Contributor Author

dcwalk commented Apr 8, 2021

Consensed / confirmed this was our policy at 2021-04-07 all hands

@dcwalk dcwalk merged commit cb571e8 into master Apr 8, 2021
@dcwalk dcwalk deleted the add-time-off branch April 8, 2021 02:13
gem "html-proofer",
# Temporary fork to allow concurrency to be set via CLI.
# See: https://github.com/gjtorikian/html-proofer/pull/632
github: "patcon/html-proofer",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel a little cautious about this approach

Copy link
Contributor

@patcon patcon Apr 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, def remove it then. i've shared my logic, and totes your call

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait, no, i thought this was something else.

Sorry, why feeling cautious? This is the self-documenting way I understand folks use package managers when waiting for upstream changes to get merged, and i'm not sure how else one goes about it... waiting on upstream to merge months later is not an approach I'm familiar with. Would forking to hyphacoop org feel more solid?

Copy link
Contributor

@patcon patcon Apr 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to hold off a bit longer, it will prob be merged in the next week: gjtorikian/html-proofer#632 (comment)

But merging stuff like this from in-process forks is totally par for the course in past positions I've worked at, and isn't usually considered a "code smell". It's just a house-keeping task to go through the manifest file every few months or so and sweep forks back to mainline or poke PR's along :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants