-
-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --hydra-config flag to override concurrency from CLI #632
Conversation
Ah, I think I may have found a bug. Seems that when JSON config was being merged from (Note the double values at the end of the output debug string in screenshot) If we instead parse JSON with |
Perhaps you could advise on whether this is an acceptable fix, before I start investigating/resolving these test failures. Seems to be an issue with checking a value called "myValue", which may be related to symbolization |
Ah, thanks for adding this! I'm confused why the keys suddenly need to be symbolized, but I don't think that has any effect on the end user, so I'm fine with it. And yes, it looks like the test just needs to be turned into a symbol key rather than a string. |
yay! thanks! will fix that 🙌 (Might be a JSON stdlib change way back, maybe was an old ruby version that worked the other way) |
* Create holidays.md * Update SUMMARY.md * restructure to finance section * fix link to finance * Added pending concurrency config. See: gjtorikian/html-proofer#632 * Moved to using html-proofer fork until upstream merge happens. * Removed misplaced typhoeus config. * Added slow version of html-proofer run. Documentation. * Update holidays.md * Update README.md Co-authored-by: Patrick Connolly <[email protected]>
k pushed fix! Should be good to merge. Thanks @gjtorikian 🙌 |
Thanks again! |
Related: #131
Thanks for considering, and thanks for all your work on maintaining this tool! :)