Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[incubator/cassandra] Fix Statefulset definition #8320

Merged
merged 4 commits into from
Oct 13, 2018
Merged

[incubator/cassandra] Fix Statefulset definition #8320

merged 4 commits into from
Oct 13, 2018

Conversation

maver1ck
Copy link
Collaborator

Signed-off-by: Maciej Bryński [email protected]

What this PR does / why we need it:

Fixes wrong statefulset definition.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer:

This is followup of #7285 which was not merged into master

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

@maver1ck
Fix Statefulset definition
2aa9fa5 
Signed-off-by: Maciej Bryński <[email protected]>
@ey-bot ey-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Oct 10, 2018
@k8s-ci-robot k8s-ci-robot requested review from foxish and linki October 10, 2018 08:13
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 10, 2018
@maver1ck maver1ck mentioned this pull request Oct 10, 2018
Closed
@kostyrev kostyrev mentioned this pull request Oct 10, 2018
Closed
2 tasks
@maeb maeb mentioned this pull request Oct 11, 2018
Closed
@maver1ck maver1ck mentioned this pull request Oct 11, 2018
Closed
6 tasks
@k8s-ci-robot
Copy link
Contributor

@maver1ck: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@maver1ck maver1ck mentioned this pull request Oct 13, 2018
Closed
@maver1ck
Copy link
Collaborator Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 13, 2018
@maver1ck
Copy link
Collaborator Author

/assign

@k8s-ci-robot
Copy link
Contributor

@maver1ck: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2018
@maver1ck
Copy link
Collaborator Author

/approve

@davidkarlsen
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidkarlsen, maver1ck

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit bbe0479 into helm:master Oct 13, 2018
This was referenced Oct 13, 2018
Closed
Closed
Closed
darioblanco pushed a commit to minddocdev/charts that referenced this pull request Oct 22, 2018
@maver1ck
[incubator/cassandra] Fix Statefulset definition (helm#8320)
8e28571 
* Fix Statefulset definition

Signed-off-by: Maciej Bryński <[email protected]>

* Bump Chart version

Signed-off-by: Maciej Bryński <[email protected]>
emas80 pushed a commit to faceit/charts that referenced this pull request Oct 24, 2018
@maver1ck @emas80
[incubator/cassandra] Fix Statefulset definition (helm#8320)
8d02834 
* Fix Statefulset definition

Signed-off-by: Maciej Bryński <[email protected]>

* Bump Chart version

Signed-off-by: Maciej Bryński <[email protected]>
Jnig pushed a commit to Jnig/charts that referenced this pull request Nov 13, 2018
@maver1ck @Jnig
[incubator/cassandra] Fix Statefulset definition (helm#8320)
93dab28 
* Fix Statefulset definition

Signed-off-by: Maciej Bryński <[email protected]>

* Bump Chart version

Signed-off-by: Maciej Bryński <[email protected]>
Signed-off-by: Jakob Niggel <[email protected]>
wgiddens pushed a commit to wgiddens/charts that referenced this pull request Jan 18, 2019
@maver1ck @wgiddens
[incubator/cassandra] Fix Statefulset definition (helm#8320)
66e3270 
* Fix Statefulset definition

Signed-off-by: Maciej Bryński <[email protected]>

* Bump Chart version

Signed-off-by: Maciej Bryński <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@foxish foxish Awaiting requested review from foxish

@linki linki Awaiting requested review from linki

Assignees

@davidkarlsen davidkarlsen

@maver1ck maver1ck

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[incubator/cassandra] invalid StatefulSet after upgrade of API version to v1 apps (was v1beta1)
4 participants
@maver1ck @k8s-ci-robot @davidkarlsen @ey-bot