Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[incubator/cassandra] Fix selector #8307

Closed
wants to merge 1 commit into from

Conversation

kostyrev
Copy link
Contributor

@kostyrev kostyrev commented Oct 9, 2018

What this PR does / why we need it:

This PR fixes

Error: release cassandra failed: StatefulSet.apps "cassandra" is invalid: [spec.selector: Required value, spec.template.metadata.labels: Invalid value: map[string]string{"app":"cassandra", "release":"cassandra"}: `selector` does not match template `labels`]

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 9, 2018
@kostyrev
Copy link
Contributor Author

kostyrev commented Oct 9, 2018

ping @KongZ

@ey-bot ey-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Oct 9, 2018
Signed-off-by: Aleksandr Kostyrev <[email protected]>
@kostyrev
Copy link
Contributor Author

There are four PRs with the same fix
#8320
#8307
#8282
#7348
Clearly there's a demand for that fix.
Could anybody merge at least one of them? Master is broken.

@KongZ
Copy link
Collaborator

KongZ commented Oct 10, 2018

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: KongZ, kostyrev
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linki

If they are not already assigned, you can assign the PR to them by writing /assign @linki in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

@KongZ: changing LGTM is restricted to assignees, and only helm/charts repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@KongZ
Copy link
Collaborator

KongZ commented Oct 10, 2018

This was look good to me but I dont' have permission to merge

@hairmare
Copy link
Contributor

/assign @linki

@davidkarlsen
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 13, 2018
@k8s-ci-robot
Copy link
Contributor

@kostyrev: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-charts-e2e 6ba612c link /test pull-charts-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@maver1ck
Copy link
Collaborator

maver1ck commented Oct 13, 2018

@kostyrev
I closed this bug by #8320
Thank you for contributing.

@davidkarlsen
Copy link
Member

Closed by #8320

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants