Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[Incubator/Cassandra] Fixes selector missing and update to 3.11.3 #7348

Closed
wants to merge 5 commits into from

Conversation

sunng87
Copy link

@sunng87 sunng87 commented Aug 25, 2018

What this PR does / why we need it:
Fixes error that spec.selector was missing from cassandra's statefulset.yml

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 25, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @sunng87. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 25, 2018
@maeb
Copy link

maeb commented Aug 27, 2018

This pull request is a duplicate of #7285.

@mattfarina mattfarina added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Aug 27, 2018
@sunng87 sunng87 force-pushed the sunng87-patch-1 branch 4 times, most recently from 9ad41f0 to c290a0f Compare August 28, 2018 14:39
@cpanato
Copy link
Member

cpanato commented Sep 3, 2018

@sunng87 please rebase and bump the chart version

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sunng87
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: davidkarlsen

If they are not already assigned, you can assign the PR to them by writing /assign @davidkarlsen in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ey-bot ey-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Sep 4, 2018
@sunng87 sunng87 changed the title [Incubator/Cassandra] Fixes selector missing [Incubator/Cassandra] Fixes selector missing and update to 3.11.3 Sep 4, 2018
@sunng87
Copy link
Author

sunng87 commented Sep 4, 2018

Updated

@MPV
Copy link
Contributor

MPV commented Sep 17, 2018

@cpanato Would be great to get this merged. 😊

@kostyrev
Copy link
Contributor

kostyrev commented Oct 9, 2018

If it's a duplicate who's gonna win?
There are two PRs resolving the same problem and yet none of them made it to master and we have broken cassandra.

@maver1ck
Copy link
Collaborator

@sunng87 This bug was fixed by #8320
Thank you for contibuting.

@sunng87
Copy link
Author

sunng87 commented Oct 14, 2018

OK. Thanks!

@sunng87 sunng87 closed this Oct 14, 2018
@sunng87 sunng87 deleted the sunng87-patch-1 branch December 20, 2018 06:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants