TF-7865 Remove beta flags for custom access for TeamProjectAccess tests #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netra2104
reviewed
Aug 16, 2023
Netra2104
previously approved these changes
Aug 16, 2023
sebasslash
requested changes
Aug 17, 2023
There was a problem hiding this comment.
👋 We don't need a changelog entry for flag removal. Please ensure that references to "This feature is still in BETA" are removed in the code docs (which are used to generated the godocs).
rberecka
force-pushed
the
TF-7865-remove-beta-flags-from-team-projects-tests
branch
2 times, most recently
from
a1ac781 to
5c9d3ab
Compare
sebasslash
previously requested changes
Aug 21, 2023
rberecka
force-pushed
the
TF-7865-remove-beta-flags-from-team-projects-tests
branch
from
8f9c3e0 to
c84092f
Compare
nfagerlund
approved these changes
Aug 22, 2023
rberecka
dismissed
sebasslash’s stale review
Nick has approved that I made Sebastian's changes.
rberecka
deleted the
TF-7865-remove-beta-flags-from-team-projects-tests
branch
|
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes skipping of Team Project Access tests using custom access now that the feature is fully GA.
Change only includes test code.
Testing plan
CI should pass
Output from tests
Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.