Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF-7865 Remove beta flags for custom access for TeamProjectAccess tests #756

Merged
merged 2 commits into from
Aug 22, 2023
Merged

TF-7865 Remove beta flags for custom access for TeamProjectAccess tests #756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c84092f
TF-7865 Remove beta flags for custom access for TeamProjectAccess tests
rberecka Aug 21, 2023
1f1cbf9
Merge branch 'main' into TF-7865-remove-beta-flags-from-team-projects…
rberecka Aug 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# UNRELEASED
<!-- Add CHANGELOG entry to this section for any PR awaiting the next release -->
* Removed beta tags for TeamProjectAccess by @rberecka [#756](https://github.com/hashicorp/go-tfe/pull/756)

# v1.32.1

## Dependency Update
Expand Down
3 changes: 1 addition & 2 deletions team_project_access.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@ var _ TeamProjectAccesses = (*teamProjectAccesses)(nil)
// TeamProjectAccesses describes all the team project access related methods that the Terraform
// Enterprise API supports
//
// TFE API docs: Documentation will be linked once this feature is available
// **Note: This functionality is still in BETA and subject to change.**
// TFE API docs: https://developer.hashicorp.com/terraform/cloud-docs/api-docs/project-team-access
type TeamProjectAccesses interface {
// List all project accesses for a given project.
List(ctx context.Context, options TeamProjectAccessListOptions) (*TeamProjectAccessList, error)
Expand Down
6 changes: 0 additions & 6 deletions team_project_access_integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,6 @@ func TestTeamProjectAccessesAdd(t *testing.T) {
})

t.Run("with valid options for all custom TeamProject permissions", func(t *testing.T) {
skipUnlessBeta(t)
options := TeamProjectAccessAddOptions{
Access: *ProjectAccess(TeamProjectAccessCustom),
Team: tmTest,
Expand Down Expand Up @@ -223,7 +222,6 @@ func TestTeamProjectAccessesAdd(t *testing.T) {
})

t.Run("with valid options for some custom TeamProject permissions", func(t *testing.T) {
skipUnlessBeta(t)
options := TeamProjectAccessAddOptions{
Access: *ProjectAccess(TeamProjectAccessCustom),
Team: tmTest,
Expand Down Expand Up @@ -303,7 +301,6 @@ func TestTeamProjectAccessesAdd(t *testing.T) {
})

t.Run("when invalid custom project permission is provided in options", func(t *testing.T) {
skipUnlessBeta(t)
tpa, err := client.TeamProjectAccess.Add(ctx, TeamProjectAccessAddOptions{
Access: *ProjectAccess(TeamProjectAccessCustom),
Team: tmTest,
Expand Down Expand Up @@ -355,7 +352,6 @@ func TestTeamProjectAccessesUpdate(t *testing.T) {
})

t.Run("with valid custom permissions attributes for all permissions", func(t *testing.T) {
skipUnlessBeta(t)
options := TeamProjectAccessUpdateOptions{
Access: ProjectAccess(TeamProjectAccessCustom),
ProjectAccess: &TeamProjectAccessProjectPermissionsOptions{
Expand Down Expand Up @@ -394,7 +390,6 @@ func TestTeamProjectAccessesUpdate(t *testing.T) {
})

t.Run("with valid custom permissions attributes for some permissions", func(t *testing.T) {
skipUnlessBeta(t)
// create tpaCustomTest to verify unupdated attributes stay the same for custom permissions
// because going from admin to read to custom changes the values of all custom permissions
tm2Test, tm2TestCleanup := createTeam(t, client, orgTest)
Expand Down Expand Up @@ -435,7 +430,6 @@ func TestTeamProjectAccessesUpdate(t *testing.T) {
assert.Equal(t, tpaCustomTest.WorkspaceAccess.WorkspaceStateVersionsPermission, tpa.WorkspaceAccess.WorkspaceStateVersionsPermission)
})
t.Run("with invalid custom permissions attributes", func(t *testing.T) {
skipUnlessBeta(t)
options := TeamProjectAccessUpdateOptions{
Access: ProjectAccess(TeamProjectAccessCustom),
ProjectAccess: &TeamProjectAccessProjectPermissionsOptions{
Expand Down