Skip to content

Commit 5c9d3ab

Browse files
committed
TF-7865 Remove beta flags for custom access for TeamProjectAccess tests
1 parent 9073f23 commit 5c9d3ab

3 files changed

+1
-8
lines changed

CHANGELOG.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
# v1.32.0
66

77
## Enhancements
8-
* Added BETA support for adding and updating custom permissions to `TeamProjectAccesses`. A `TeamProjectAccessType` of `"custom"` can set various permissions applied at
8+
* Added support for adding and updating custom permissions to `TeamProjectAccesses`. A `TeamProjectAccessType` of `"custom"` can set various permissions applied at
99
the project level to the project itself (`TeamProjectAccessProjectPermissionsOptions`) and all of the workspaces in a project (`TeamProjectAccessWorkspacePermissionsOptions`) by @rberecka [#745](https://github.com/hashicorp/go-tfe/pull/745)
1010
* Added BETA field `Provisional` to `ConfigurationVersions` by @brandonc [#746](https://github.com/hashicorp/go-tfe/pull/746)
1111

team_project_access.go

-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ var _ TeamProjectAccesses = (*teamProjectAccesses)(nil)
1616
// Enterprise API supports
1717
//
1818
// TFE API docs: Documentation will be linked once this feature is available
19-
// **Note: This functionality is still in BETA and subject to change.**
2019
type TeamProjectAccesses interface {
2120
// List all project accesses for a given project.
2221
List(ctx context.Context, options TeamProjectAccessListOptions) (*TeamProjectAccessList, error)

team_project_access_integration_test.go

-6
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,6 @@ func TestTeamProjectAccessesAdd(t *testing.T) {
166166
})
167167

168168
t.Run("with valid options for all custom TeamProject permissions", func(t *testing.T) {
169-
skipUnlessBeta(t)
170169
options := TeamProjectAccessAddOptions{
171170
Access: *ProjectAccess(TeamProjectAccessCustom),
172171
Team: tmTest,
@@ -223,7 +222,6 @@ func TestTeamProjectAccessesAdd(t *testing.T) {
223222
})
224223

225224
t.Run("with valid options for some custom TeamProject permissions", func(t *testing.T) {
226-
skipUnlessBeta(t)
227225
options := TeamProjectAccessAddOptions{
228226
Access: *ProjectAccess(TeamProjectAccessCustom),
229227
Team: tmTest,
@@ -303,7 +301,6 @@ func TestTeamProjectAccessesAdd(t *testing.T) {
303301
})
304302

305303
t.Run("when invalid custom project permission is provided in options", func(t *testing.T) {
306-
skipUnlessBeta(t)
307304
tpa, err := client.TeamProjectAccess.Add(ctx, TeamProjectAccessAddOptions{
308305
Access: *ProjectAccess(TeamProjectAccessCustom),
309306
Team: tmTest,
@@ -355,7 +352,6 @@ func TestTeamProjectAccessesUpdate(t *testing.T) {
355352
})
356353

357354
t.Run("with valid custom permissions attributes for all permissions", func(t *testing.T) {
358-
skipUnlessBeta(t)
359355
options := TeamProjectAccessUpdateOptions{
360356
Access: ProjectAccess(TeamProjectAccessCustom),
361357
ProjectAccess: &TeamProjectAccessProjectPermissionsOptions{
@@ -394,7 +390,6 @@ func TestTeamProjectAccessesUpdate(t *testing.T) {
394390
})
395391

396392
t.Run("with valid custom permissions attributes for some permissions", func(t *testing.T) {
397-
skipUnlessBeta(t)
398393
// create tpaCustomTest to verify unupdated attributes stay the same for custom permissions
399394
// because going from admin to read to custom changes the values of all custom permissions
400395
tm2Test, tm2TestCleanup := createTeam(t, client, orgTest)
@@ -435,7 +430,6 @@ func TestTeamProjectAccessesUpdate(t *testing.T) {
435430
assert.Equal(t, tpaCustomTest.WorkspaceAccess.WorkspaceStateVersionsPermission, tpa.WorkspaceAccess.WorkspaceStateVersionsPermission)
436431
})
437432
t.Run("with invalid custom permissions attributes", func(t *testing.T) {
438-
skipUnlessBeta(t)
439433
options := TeamProjectAccessUpdateOptions{
440434
Access: ProjectAccess(TeamProjectAccessCustom),
441435
ProjectAccess: &TeamProjectAccessProjectPermissionsOptions{

0 commit comments

Comments
 (0)