boot: update the bootargs.cfg #516

Vicente-Cheng · 2023-06-27T11:02:20Z

Problem:
We must update the bootargs.cfg due to new elemental-toolkits.
Or we could not find root partition

Solution:
Update bootargs.cfg

Related Issue:
harvester/harvester#4113

Test plan:
Tested with fresh installation and upgrade

guangbochen · 2023-06-28T02:14:13Z

scripts/package-harvester-os

@@ -17,7 +17,7 @@ source ${SCRIPTS_DIR}/version-harvester ${TOP_DIR}/../harvester
 source ${SCRIPTS_DIR}/version-monitoring
 source ${SCRIPTS_DIR}/version-logging

-BASE_OS_IMAGE="rancher/harvester-os:20230615"
+BASE_OS_IMAGE="rancher/harvester-os:sle-micro-head"


do we need to set a fixed version for a new release or plan to use the head instead?

Yes, we need it. @Vicente-Cheng Please help create a new tag on the harvester-v1.2.x branch.

Hi @guangbochen,
We prefer to use sle-micro-head for the master branch.
And now, when we tag the OS image like v1.2-20230629 or v1.1-20230628 (for example).
The GitHub action will create PR to the related installer branch, so we could make master branch use sle-micro-head image for development. cc @bk201

bk201

LGTM

guangbochen

LGTM, thanks.

masteryyh · 2023-06-30T04:18:54Z

Cannot boot into Harvester using the ISO built from this branch...
After installed and rebooted it always goes in installation screen, even the virtual CDROM is not inserted.
Using harvester/harvester master branch, installed on Hyper-V

Vicente-Cheng · 2023-06-30T04:43:40Z

Cannot boot into Harvester using the ISO built from this branch... After installed and rebooted it always goes in installation screen, even the virtual CDROM is not inserted. Using harvester/harvester master branch, installed on Hyper-V

Update the 91_installer.yaml, caused by the root label change.
Only affect the dashboard display. The installation is successful.

Vicente-Cheng · 2023-06-30T04:47:14Z

I also found the debug menu could not display as usual.
Change this to draft until I fix that.

Vicente-Cheng · 2023-06-30T05:21:14Z

Updated, the debug menu is back

masteryyh

LGTM, thanks.

bk201 · 2023-06-30T09:22:29Z

Tow places might need modify, still using COS_ACTIVE label:

harvester-installer/package/harvester-os/files/system/oem/07_kdump.yaml

Line 5 in 73619b4

if: 'grep -q root=LABEL=COS_ACTIVE /proc/cmdline && [ -n "$(blkid -L COS_ACTIVE)" ]'
https://github.com/harvester/os2/blob/ee73a9a10a786929a12431e6a0dc3624ee0852f5/files/system/oem/00_rootfs.yaml#L42

- we need to update the /proc/cmdline for looks cos_state as root - use latest sle-micro baseOS image as dev branch - change some oem files that depend on the old root label Signed-off-by: Vicente Cheng <[email protected]>

Vicente-Cheng · 2023-07-03T02:16:27Z

Tow places might need modify, still using COS_ACTIVE label:

harvester-installer/package/harvester-os/files/system/oem/07_kdump.yaml

Line 5 in 73619b4

if: 'grep -q root=LABEL=COS_ACTIVE /proc/cmdline && [ -n "$(blkid -L COS_ACTIVE)" ]'

https://github.com/harvester/os2/blob/ee73a9a10a786929a12431e6a0dc3624ee0852f5/files/system/oem/00_rootfs.yaml#L42

Thanks for the reminder!
Update for os2: harvester/os2#74
Installer has also been updated!

bk201 · 2023-07-03T02:33:26Z

Stuck at booting after upgrading the first node, probably due to label change?

cmdline:

Vicente-Cheng · 2023-07-03T07:40:24Z

Stuck at booting after upgrading the first node, probably due to label change?
cmdline:

Yes, we still need the latest elemental when we upgrade from v1.1.2.
Related to PR: harvester/harvester#4164

bk201

LGTM

guangbochen

LGTM, thanks.

Vicente-Cheng · 2023-07-04T02:01:32Z

@mergify v1.2

mergify · 2023-07-04T02:01:34Z

v1 .2

❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚.

Vicente-Cheng · 2023-07-04T02:02:24Z

@Mergifyio backport v1.2

mergify · 2023-07-04T02:02:27Z

backport v1.2

✅ Backports have been created

#524 boot: update the bootargs.cfg (backport #516) has been created for branch v1.2

Vicente-Cheng requested review from bk201, guangbochen and masteryyh June 27, 2023 11:02

guangbochen reviewed Jun 28, 2023

View reviewed changes

bk201 approved these changes Jun 29, 2023

View reviewed changes

Vicente-Cheng mentioned this pull request Jun 29, 2023

Bump OS v1.2-20230629 #517

Merged

guangbochen approved these changes Jun 29, 2023

View reviewed changes

Vicente-Cheng force-pushed the bump-elemental branch from f775401 to 8701c2a Compare June 30, 2023 04:42

Vicente-Cheng marked this pull request as draft June 30, 2023 04:47

Vicente-Cheng force-pushed the bump-elemental branch from 8701c2a to b7c704b Compare June 30, 2023 05:20

Vicente-Cheng marked this pull request as ready for review June 30, 2023 05:20

Vicente-Cheng requested review from bk201 and guangbochen June 30, 2023 05:42

masteryyh approved these changes Jun 30, 2023

View reviewed changes

boot: update the bootargs.cfg

c730836

- we need to update the /proc/cmdline for looks cos_state as root - use latest sle-micro baseOS image as dev branch - change some oem files that depend on the old root label Signed-off-by: Vicente Cheng <[email protected]>

Vicente-Cheng force-pushed the bump-elemental branch from b7c704b to c730836 Compare July 3, 2023 02:03

bk201 approved these changes Jul 4, 2023

View reviewed changes

guangbochen approved these changes Jul 4, 2023

View reviewed changes

guangbochen merged commit 08ad34a into harvester:master Jul 4, 2023

mergify bot mentioned this pull request Jul 4, 2023

boot: update the bootargs.cfg (backport #516) #524

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

boot: update the bootargs.cfg #516

boot: update the bootargs.cfg #516

Vicente-Cheng commented Jun 27, 2023

guangbochen Jun 28, 2023

bk201 Jun 28, 2023

Vicente-Cheng Jun 29, 2023

bk201 left a comment

guangbochen left a comment

masteryyh commented Jun 30, 2023

Vicente-Cheng commented Jun 30, 2023

Vicente-Cheng commented Jun 30, 2023

Vicente-Cheng commented Jun 30, 2023

masteryyh left a comment

bk201 commented Jun 30, 2023

Vicente-Cheng commented Jul 3, 2023

bk201 commented Jul 3, 2023 •

edited

Loading

Vicente-Cheng commented Jul 3, 2023

bk201 left a comment

guangbochen left a comment

Vicente-Cheng commented Jul 4, 2023

mergify bot commented Jul 4, 2023

Vicente-Cheng commented Jul 4, 2023

mergify bot commented Jul 4, 2023 •

edited

Loading

boot: update the bootargs.cfg #516

boot: update the bootargs.cfg #516

Conversation

Vicente-Cheng commented Jun 27, 2023

guangbochen Jun 28, 2023

Choose a reason for hiding this comment

bk201 Jun 28, 2023

Choose a reason for hiding this comment

Vicente-Cheng Jun 29, 2023

Choose a reason for hiding this comment

bk201 left a comment

Choose a reason for hiding this comment

guangbochen left a comment

Choose a reason for hiding this comment

masteryyh commented Jun 30, 2023

Vicente-Cheng commented Jun 30, 2023

Vicente-Cheng commented Jun 30, 2023

Vicente-Cheng commented Jun 30, 2023

masteryyh left a comment

Choose a reason for hiding this comment

bk201 commented Jun 30, 2023

Vicente-Cheng commented Jul 3, 2023

bk201 commented Jul 3, 2023 • edited Loading

Vicente-Cheng commented Jul 3, 2023

bk201 left a comment

Choose a reason for hiding this comment

guangbochen left a comment

Choose a reason for hiding this comment

Vicente-Cheng commented Jul 4, 2023

mergify bot commented Jul 4, 2023

❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚.

Vicente-Cheng commented Jul 4, 2023

mergify bot commented Jul 4, 2023 • edited Loading

✅ Backports have been created

bk201 commented Jul 3, 2023 •

edited

Loading

mergify bot commented Jul 4, 2023 •

edited

Loading