Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Bump elemental-toolkits #4113

Closed
Vicente-Cheng opened this issue Jun 20, 2023 · 5 comments
Closed

[ENHANCEMENT] Bump elemental-toolkits #4113

Vicente-Cheng opened this issue Jun 20, 2023 · 5 comments
Assignees
Labels
area/os Harvester OS related (ex: SLE Micro) kind/enhancement Issues that improve or augment existing functionality
Milestone

Comments

@Vicente-Cheng
Copy link
Contributor

Vicente-Cheng commented Jun 20, 2023

Is your enhancement related to a problem? Please describe.
Bump the new elemental-toolkits with Harvester OS.
We use the elemental-cli from luet. That is an old version. We want to use newer elemental-toolkits on OBS.

Describe the solution you'd like
Bump elemental-toolkits

Describe alternatives you've considered
None

Additional context
Another similar issue: #3587

@Vicente-Cheng Vicente-Cheng added kind/enhancement Issues that improve or augment existing functionality area/os Harvester OS related (ex: SLE Micro) labels Jun 20, 2023
@Vicente-Cheng Vicente-Cheng added this to the v1.2.0 milestone Jun 20, 2023
@Vicente-Cheng Vicente-Cheng self-assigned this Jun 20, 2023
@harvesterhci-io-github-bot
Copy link
Collaborator

harvesterhci-io-github-bot commented Jul 4, 2023

Pre Ready-For-Testing Checklist

* [ ] If labeled: require/HEP Has the Harvester Enhancement Proposal PR submitted?
The HEP PR is at:

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:

Test Plan:

* [ ] Is there a workaround for the issue? If so, where is it documented?
The workaround is at:

* [ ] Have the backend code been merged (harvester, harvester-installer, etc) (including backport-needed/*)?
The PR is at:

* [ ] Does the PR include the explanation for the fix or the feature?

* [ ] Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart?
The PR for the YAML change is at:
The PR for the chart change is at:

* [ ] If labeled: area/ui Has the UI issue filed or ready to be merged?
The UI issue/PR is at:

* [ ] If labeled: require/doc, require/knowledge-base Has the necessary document PR submitted or merged?
The documentation/KB PR is at:

* [ ] If NOT labeled: not-require/test-plan Has the e2e test plan been merged? Have QAs agreed on the automation test case? If only test case skeleton w/o implementation, have you created an implementation issue?
- The automation skeleton PR is at:
- The automation test case PR is at:

* [ ] If the fix introduces the code for backward compatibility Has a separate issue been filed with the label release/obsolete-compatibility?
The compatibility issue is filed at:

@harvesterhci-io-github-bot
Copy link
Collaborator

Automation e2e test issue: harvester/tests#883

@irishgordo
Copy link
Contributor

@Vicente-Cheng this seems to look good 😄 👍

I'm able to note:

t:/home/rancher # cat /etc/os-release 
NAME="SLE Micro"
VERSION="5.3"
VERSION_ID="5.3"
PRETTY_NAME="Harvester v1.2"
ID="sle-micro-rancher"
ID_LIKE="suse"
ANSI_COLOR="0;32"
CPE_NAME="cpe:/o:suse:sle-micro-rancher:5.3"
VARIANT="Harvester"
VARIANT_ID="Harvester-v1.2-20230629"
GRUB_ENTRY_NAME="Harvester v1.2"
t:/home/rancher # env
HOSTTYPE=x86_64
LESSCLOSE=lessclose.sh %s %s
XKEYSYMDB=/usr/X11R6/lib/X11/XKeysymDB
LANG=POSIX
WINDOWMANAGER=xterm
LESS=-M -I -R
SUDO_GID=1000
HOSTNAME=t
KUBECONFIG=/etc/rancher/rke2/rke2.yaml
CSHEDIT=emacs
GPG_TTY=/dev/pts/0
LESS_ADVANCED_PREPROCESSOR=no
COLORTERM=1
SUDO_COMMAND=/usr/bin/su
MACHTYPE=x86_64-suse-linux
MINICOM=-c on
CONTAINERD_ADDRESS=/run/k3s/containerd/containerd.sock
OSTYPE=linux
XDG_SESSION_ID=2
USER=root
PAGER=less
MORE=-sl
PWD=/home/rancher
HOME=/root
LC_CTYPE=en_US.UTF-8
HOST=t
SUDO_USER=rancher
XNLSPATH=/usr/X11R6/lib/X11/nls
XDG_SESSION_TYPE=tty
XDG_DATA_DIRS=/usr/share
PROFILEREAD=true
IMAGE_SERVICE_ENDPOINT=unix:///var/run/k3s/containerd/containerd.sock
SUDO_UID=65535
MAIL=/var/mail/root
LESSKEY=/etc/lesskey.bin
SHELL=/bin/bash
TERM=xterm-256color
XDG_SESSION_CLASS=user
CONTAINER_RUNTIME_ENDPOINT=unix:///var/run/k3s/containerd/containerd.sock
SHLVL=1
MANPATH=
LOGNAME=root
XDG_RUNTIME_DIR=/run/user/0
XDG_CONFIG_DIRS=/etc/xdg
PATH=/sbin:/usr/sbin:/usr/local/sbin:/root/bin:/usr/local/bin:/usr/bin:/bin:/var/lib/rancher/rke2/bin
G_BROKEN_FILENAMES=1
HISTSIZE=1000
CPU=x86_64
LESSOPEN=lessopen.sh %s
_=/usr/bin/env
t:/home/rancher # rpm -qa | grep virtctl
kubevirt-virtctl-0.54.0-150400.3.18.10.x86_64
t:/home/rancher # rpm -qa | grep yip
yip-v1.0.0-150400.1.1.x86_64

Also able to visually audit the grub kernel edits:
Screenshot from 2023-07-06 16-25-37
Screenshot from 2023-07-06 16-23-50
Screenshot from 2023-07-06 16-23-28
Screenshot from 2023-07-06 16-16-26

And also able to verify:

t:/home/rancher # rpm -qa | grep -ie "elemental"
elemental-dracut-config-0.10.7-150400.1.1.noarch
elemental-grub-config-0.10.7-150400.1.1.noarch
elemental-immutable-rootfs-0.10.7-150400.1.1.noarch
elemental-cli-0.3.1-150400.2.2.x86_64
elemental-init-setup-0.10.7-150400.1.1.noarch
elemental-init-services-0.10.7-150400.1.1.noarch
elemental-init-recovery-0.10.7-150400.1.1.noarch
elemental-init-network-0.10.7-150400.1.1.noarch
elemental-init-live-0.10.7-150400.1.1.noarch
elemental-init-boot-assessment-0.10.7-150400.1.1.noarch
elemental-init-config-0.10.7-150400.1.1.noarch
elemental-toolkit-0.10.7-150400.1.1.noarch
t:/home/rancher # elemental version
0.3.1+gbab71d1

Validation Question:

  • Is there something additionally with regards to the elemental-toolkits that I should look at on the built iso?

@Vicente-Cheng
Copy link
Contributor Author

Vicente-Cheng commented Jul 10, 2023

@Vicente-Cheng this seems to look good 😄 👍

Validation Question:

  • Is there something additionally with regards to the elemental-toolkits that I should look at on the built iso?

Hi @irishgordo,
Let's check the installation, and the upgrade should work as usual.
The main changes for us with bumping elemental version would be the bootup flow and partition label.
These two cases could be validated by installation and upgrade.
So we need to check the elemental version and ensure the installation (both ipxe/interactive mode) and upgrade work well as usual.

@irishgordo
Copy link
Contributor

@Vicente-Cheng
Testing the upgrade from v1.1.2 -> v1.2.0-rc3 (2 node qemu/kvm) looks good 😄
The Labels seem to look good too.
And the ipxe install works great as well.
Screenshot from 2023-07-10 11-42-17
Screenshot from 2023-07-10 11-14-54
Screenshot from 2023-07-10 11-14-27
Screenshot from 2023-07-10 11-14-05
Screenshot from 2023-07-10 11-10-57
So I'll go ahead and close this out 👍 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/os Harvester OS related (ex: SLE Micro) kind/enhancement Issues that improve or augment existing functionality
Projects
None yet
Development

No branches or pull requests

4 participants