Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: change the root label checking from COS_ACTIVE to COS_STATE #74

Conversation

Vicente-Cheng
Copy link
Collaborator

@Vicente-Cheng Vicente-Cheng commented Jul 3, 2023

- We introduce the new elemental-toolkit. There is a main change
  for the root label from COS_ACTIVE to COS_STATE so we need to
  change the related checking.

@bk201
Copy link
Member

bk201 commented Jul 3, 2023

LGTM, It would be nice to have a PR description.

    - We introduce the new elemental-toolkit. There is a main change
      for the root label from COS_ACTIVE to COS_STATE so we need to
      change the related checking.

Signed-off-by: Vicente Cheng <[email protected]>
@Vicente-Cheng Vicente-Cheng force-pushed the change_cos_active_to_cos_state branch from aed924f to 30f6bd4 Compare July 4, 2023 01:41
@Vicente-Cheng
Copy link
Collaborator Author

LGTM, It would be nice to have a PR description.

Thanks for the reminder! updated!

Copy link

@masteryyh masteryyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@Vicente-Cheng Vicente-Cheng merged commit d5b7835 into harvester:sle-micro Jul 4, 2023
@Vicente-Cheng
Copy link
Collaborator Author

@Mergifyio backport harvester-v1.2.x

@mergify
Copy link

mergify bot commented Jul 4, 2023

backport harvester-v1.2.x

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants